8000 refactor(state): use DestroyRef within EffectsService by michaelbe812 · Pull Request #1831 · rx-angular/rx-angular · GitHub
[go: up one dir, main page]
Skip to content

refactor(state): use DestroyRef within EffectsService #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

refactor(state): use DestroyRef within EffectsService #1831

merged 1 commit into from
Jan 7, 2025

Conversation

michaelbe812
Copy link
Contributor

Use modern DestroyRef also within RxEffects

@github-actions github-actions bot added the { } State @rx-angular/state related label Jan 5, 2025
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jan 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c1d835d.

Command Status Duration Result
nx affected -t lint build test component-test e... ✅ Succeeded 1m 22s View ↗
nx build docs ✅ Succeeded 20s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 08:03:53 UTC

JeanMeche
JeanMeche reviewed Jan 6, 2025
View reviewed changes
@michaelbe812 michaelbe812 force-pushed the f/refactor-rx-effects-to-use-destroy-ref branch from 7202073 to c1d835d Compare January 6, 2025 04:50
@michaelbe812
Copy link
Contributor Author

CI fails bc of a 429 to url https://medium.com/itnext/incremental-static-regeneration-for-angular-42b0a8440e53
Probably it is enough to just re run it (locally everything is fine)
However it seems like I do not have the rights to restart the Pipeline

@hoebbelsB
Copy link
Member

CI fails bc of a 429 to url https://medium.com/itnext/incremental-static-regeneration-for-angular-42b0a8440e53 Probably it is enough to just re run it (locally everything is fine) However it seems like I do not have the rights to restart the Pipeline

yeah that step is flaky af...

@hoebbelsB hoebbelsB merged commit 07570f5 into rx-angular:main Jan 7, 2025
7 checks passed
@michaelbe812 michaelbe812 deleted the f/refactor-rx-effects-to-use-destroy-ref branch January 8, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@hoebbelsB hoebbelsB hoebbelsB approved these changes

@edbzn edbzn edbzn approved these changes

Assignees
No one assigned
Labels
{ } State @rx-angular/state related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbe812 @hoebbelsB @JeanMeche @edbzn
0