8000 refactor(state): use DestroyRef instead of OnDestroy life cycle hook by michaelbe812 · Pull Request #1828 · rx-angular/rx-angular · GitHub
[go: up one dir, main page]
Skip to content

refactor(state): use DestroyRef instead of OnDestroy life cycle hook #1828

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2025
Merged

refactor(state): use DestroyRef instead of OnDestroy life cycle hook #1828

merged 3 commits into from
Jan 8, 2025

Conversation

michaelbe812
Copy link
Contributor

Use modern DestroyRef instead of OnDestroy lifecycle hook

@github-actions github-actions bot added the { } State @rx-angular/state related label Jan 3, 2025
@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Jan 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c5e8d2d.

Command Status Duration Result
nx affected -t lint build test component-test e... ✅ Succeeded 51s View ↗
nx build docs ✅ Succeeded 31s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 04:28:48 UTC

edbzn
edbzn reviewed Jan 5, 2025
View reviewed changes
@github-actions github-actions bot added the 🛂 Test Unit tests, e2e tests, integration tests, test coverage label Jan 5, 2025
JeanMeche
JeanMeche reviewed Jan 6, 2025
View reviewed changes
@michaelbe812 michaelbe812 force-pushed the f/refactor-rx-state-to-use-destroy-ref branch 2 times, most recently from 933dcea to 7043b41 Compare January 6, 2025 04:56
hoebbelsB
hoebbelsB approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member
@hoebbelsB hoebbelsB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelbe812 michaelbe812 force-pushed the f/refactor-rx-state-to-use-destroy-ref branch from aba2ee5 to c5e8d2d Compare January 7, 2025 04:26
@hoebbelsB hoebbelsB merged commit 70a590d into rx-angular:main Jan 8, 2025
7 checks passed
@michaelbe812 michaelbe812 deleted the f/refactor-rx-state-to-use-destroy-ref branch January 8, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@edbzn edbzn edbzn left review comments

@hoebbelsB hoebbelsB hoebbelsB approved these changes

Assignees
No one assigned
Labels
{ } State @rx-angular/state related 🛂 Test Unit tests, e2e tests, integration tests, test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelbe812 @JeanMeche @hoebbelsB @edbzn
0