Remove deprecated APIs #1511
Remove deprecated APIs #1511
Conversation
- Drop global render-strategy (cdk)
- Drop transformations and selections in the main entry-point (state)
- Drop zone-less/rxjs wrappers (cdk)
BREAKING CHANGE: The global render-strategy is no longer available.
BREAKING CHANGE: The state library no longer export the transformation-helpers, they are now available under `@rx-angular/cdk/transformations`. Selections operators are no longer exported in the main entrypoint `@rx-angular/state`, they are now available under `@rx-angular/state/selections`.
BREAKING CHANGE: The cdk library no longer export the set of zone-less RxJS wrappers, they moved in a [new repository](https://github.com/rx-angular/rxjs-zone-less) and now available under `rxjs-zone-less` on NPM.
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit ce7889a. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
@edbzn thx for the PR. the changes look good. I just want to mention some things.
We should check that if the updated unit tests in the base branch should be moved to https://github.com/rx-angular/rxjs-zone-less. This is also true for any deleted documentation.
Also, should we provide a migration script for deprecations that can be replaced with other paths ?
@hoebbelsB I'm not sure to get what you mean, should the updated tests from this PR #1509 be backported to https://github.com/rx-angular/rxjs-zone-less? Because there's nothing new in the base branch regarding rxjs-zone-less.
The migration already exist and was provi 8000 ded for state v1.4.7: const renames: Record<string, string | [string, string]> = {
createSideEffectObservable: '@rx-angular/state/selections',
createAccumulationObservable: '@rx-angular/state/selections',
select: '@rx-angular/state/selections',
stateful: '@rx-angular/state/selections',
distinctUntilSomeChanged: '@rx-angular/state/selections',
selectSlice: '@rx-angular/state/selections',
KeyCompareMap: '@rx-angular/state/selections',
CompareFn: '@rx-angular/state/selections',
PickSlice: '@rx-angular/state/selections',
insert: '@rx-angular/cdk/transformations',
remove: '@rx-angular/cdk/transformations',
toDictionary: '@rx-angular/cdk/transformations',
update: '@rx-angular/cdk/transformations',
extract: '@rx-angular/cdk/transformations',
upsert: '@rx-angular/cdk/transformations',
setProp: '@rx-angular/cdk/transformations',
patch: '@rx-angular/cdk/transformations',
deleteProp: '@rx-angular/cdk/transformations',
dictionaryToArray: '@rx-angular/cdk/transformations',
toggle: '@rx-angular/cdk/transformations',
slice: '@rx-angular/cdk/transformations',
RxState: '@rx-angular/state',
}; |
Yes, I mean backporting the updated tests
Great, should we change it to run again with the next version? |
|
@edbzn moved the tests: rx-angular/rxjs-zone-less#7 |