8000 Add TruffleRuby 33.0.1 by eregon · Pull Request #5626 · rvm/rvm · GitHub
[go: up one dir, main page]
Skip to content

Add TruffleRuby 33.0.1#5626

Merged
pkuczynski merged 2 commits intorvm:masterfrom
eregon:truffleruby-33.0.1
Jan 23, 2026
Merged

Add TruffleRuby 33.0.1#5626
pkuczynski merged 2 commits intorvm:masterfrom
eregon:truffleruby-33.0.1

Conversation

@eregon
Copy link
Contributor
@eregon eregon commented Jan 21, 2026

@eregon eregon added this to the rvm-1.29.13 milestone Jan 21, 2026
Copilot AI review requested due to automatic review settings January 21, 2026 18:48
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link
Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds TruffleRuby version 33.0.1 to the RVM project by updating configuration files with checksums and version references.

Changes:

  • Added MD5 and SHA512 checksums for TruffleRuby 33.0.1 across all 4 supported platforms (linux-amd64, linux-aarch64, macos-amd64, macos-aarch64)
  • Updated default TruffleRuby version from 33.0.0 to 33.0.1 in configuration files
  • Updated changelog to include version 33.0.1

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/sha512 Added SHA512 checksums for TruffleRuby 33.0.1 for all 4 platforms
config/md5 Added MD5 checksums for TruffleRuby 33.0.1 for all 4 platforms
config/known_strings Added truffleruby-33.0.1 version string
config/known Updated default TruffleRuby version to 33.0.1
config/db Updated truffleruby_version variable to 33.0.1
CHANGELOG.md Added 33.0.1 to the list of TruffleRuby versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eregon eregon requested a review from pkuczynski January 21, 2026 19:09
pkuczynski
pkuczynski previously approved these changes Jan 22, 2026
View reviewed changes
@pkuczynski pkuczynski enabled auto-merge (squash) January 22, 2026 09:00
@pkuczynski pkuczynski disabled auto-merge January 22, 2026 09:00
@eregon
Copy link
Contributor Author
eregon commented Jan 22, 2026

Looks like https://github.com/rvm/rvm/actions/runs/21221719355/job/61057951258?pr=5626 hanged during download, I'll just restart it then

@eregon
Copy link
Contributor Author
eregon commented Jan 22, 2026

Actually the download seems fine since it reached 100%.
Is there a way to run tf in verbose mode so it prints the command it runs?

@eregon
Copy link
Contributor Author
eregon commented Jan 22, 2026 •
edited
Loading

Found TF_DEBUG=1.
The output on Linux https://github.com/rvm/rvm/actions/runs/21243344041/job/61126362720?pr=5626#step:5:69
looks a bit weird because the download output is before ##### starting test truffleruby. which does not make sense timing-wise.
Maybe tf or RVM (or GitHub Actions) is buffering/delaying stdout but not stderr?

On macos-latest it looks stuck just after the download like in in the previous runs on this PR:
https://github.com/rvm/rvm/actions/runs/21243344041/job/61126362729?pr=5626
Not printing any command that tf runs nor even ##### starting test truffleruby..

@eregon
Copy link
Contributor Author
eregon commented Jan 22, 2026

Maybe tf or RVM (or GitHub Actions) is buffering/capturing/delaying stdout but not stderr?

tf must capture output for tests like

rvm install truffleruby # status=0; match!=/Already installed/; match=/compiling c-extensions/

But ideally it'd print a line as soon as it receives it or so.
(TruffleRuby itself doesn't do write buffering so that should be no issue.)

Not quite sure how to debug this.

@pkuczynski pkuczynski merged commit e36aa19 into rvm:master Jan 23, 2026
39 of 43 checks passed
@pkuczynski
Copy link
Member
pkuczynski commented Jan 23, 2026

I merged it for now and we can see if we can debug it somehow later...

@eregon
Copy link
Contributor Author
eregon commented Jan 23, 2026

Thanks, @nirvdrum tried to reproduce locally on macOS but could not.
The issue seems independent of the new version and somewhat transient.

I noticed master doesn't run the CI: https://github.com/rvm/rvm/commits/master
I'll make a PR to enable that, so we have a better idea if master is already broken due to some external change/transient or not.

@eregon eregon mentioned this pull request Jan 23, 2026
Closed
@eregon
Copy link
Contributor Author
eregon commented Jan 28, 2026 •
edited
Loading

I think #5632 (comment) makes it clear it's not related to truffleruby but a general problem of rvm CI on macOS, which started happening for unknown reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pkuczynski pkuczynski pkuczynski left review comments

Assignees

No one assigned

Labels

interpreter: truffleruby

Projects

None yet

Milestone

rvm-1.29.13

Development

Successfully merging this pull request may close these issues.

3 participants

@eregon @pkuczynski
0