10000 Minor API tweaks by djc · Pull Request #253 · rustls/rcgen · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor API tweaks #253

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Minor API tweaks #253

merged 2 commits into from
Mar 20, 2024

Conversation

djc
Copy link
Member
@djc djc commented Mar 20, 2024

These are non-semver-breaking so they don't need to block the release, but I think they are a natural addition to API changes we've already made (moving KeyPair out of CertificateParams and storing *Der types internally).

djc added 2 commits March 20, 2024 17:18
@djc
Derive Clone for CertificateParams
3cbbe28 
Now that this no longer contains private key material, this seems sensible.
@djc
Allow taking owned pki-types out of wrappers
372bdcd
@djc djc requested review from cpu and est31 March 20, 2024 16:22
@djc djc added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit c9b6129 Mar 20, 2024
40 of 42 checks passed
@djc djc deleted the api-tweaks branch March 20, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@est31 est31 est31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @est31
0