8000 Comparing main...volatile-cell · rust-osdev/volatile · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-osdev/volatile
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: rust-osdev/volatile
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: volatile-cell
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 17, 2023

  1. Revert removal of the VolatileCell type 

    This reverts commit 8e71845.
    @phil-opp
    phil-opp committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    130410b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Use UnsafeCell::raw_get instead of get

    @phil-opp
    phil-opp committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    024ac78 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Take &self instead of &mut self in write methods 

    Taking `&mut self` is not possible because the compiler will make too many guarantees to LLVM in this case, e.g. that spurious reads of the wrapped value are permitted.

Because of this change, the `VolatileCell` type must be `!Sync`. However, it can still be `Send`, so it can still be used in statics when it's wrapped in a `Mutex`.
    @phil-opp
    phil-opp committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    2141a87 View commit details
    Browse the repository at this point in the history
Loading
0