Use UnsafeCell::raw_get instead of get

phil-opp · phil-opp · commit 024ac780a7fa · 2023-01-20T18:46:27.000+01:00
diff --git a/src/cell.rs b/src/cell.rs
@@ -128,7 +128,12 @@ impl<T, A> VolatileCell<T, A> {
 
     pub fn as_ptr(&self) -> VolatilePtr<T, ReadOnly> {
         // UNSAFE: Safe, as we know that our internal value exists.
-        unsafe { VolatilePtr::new_restricted(ReadOnly, NonNull::new_unchecked(self.value.get())) }
+        unsafe {
+            VolatilePtr::new_restricted(
+                ReadOnly,
+                NonNull::new_unchecked(UnsafeCell::raw_get(&self.value)),
+            )
+        }
     }
 
     pub fn as_mut_ptr(&mut self) -> VolatilePtr<T, A>
@@ -137,7 +142,10 @@ impl<T, A> VolatileCell<T, A> {
     {
         // UNSAFE: Safe, as we know that our internal value exists.
         unsafe {
-            VolatilePtr::new_restricted(A::default(), NonNull::new_unchecked(self.value.get()))
+            VolatilePtr::new_restricted(
+                A::default(),
+                NonNull::new_unchecked(UnsafeCell::raw_get(&self.value)),
+            )
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,12 @@ impl<T, A> VolatileCell<T, A> {`
`128`	`128`
`129`	`129`	`pub fn as_ptr(&self) -> VolatilePtr<T, ReadOnly> {`
`130`	`130`	`// UNSAFE: Safe, as we know that our internal value exists.`
`131`		`- unsafe { VolatilePtr::new_restricted(ReadOnly, NonNull::new_unchecked(self.value.get())) }`
	`131`	`+ unsafe {`
	`132`	`+ VolatilePtr::new_restricted(`
	`133`	`+ ReadOnly,`
	`134`	`+ NonNull::new_unchecked(UnsafeCell::raw_get(&self.value)),`
	`135`	`+ )`
	`136`	`+ }`
`132`	`137`	`}`
`133`	`138`
`134`	`139`	`pub fn as_mut_ptr(&mut self) -> VolatilePtr<T, A>`
`@@ -137,7 +142,10 @@ impl<T, A> VolatileCell<T, A> {`
`137`	`142`	`{`
`138`	`143`	`// UNSAFE: Safe, as we know that our internal value exists.`
`139`	`144`	`unsafe {`
`140`		`- VolatilePtr::new_restricted(A::default(), NonNull::new_unchecked(self.value.get()))`
	`145`	`+ VolatilePtr::new_restricted(`
	`146`	`+ A::default(),`
	`147`	`+ NonNull::new_unchecked(UnsafeCell::raw_get(&self.value)),`
	`148`	`+ )`
`141`	`149`	`}`
`142`	`150`	`}`
`143`	`151`