8000 Rename Zip::apply to for_each including other apply methods by bluss · Pull Request #894 · rust-ndarray/ndarray · GitHub
[go: up one dir, main page]

Skip to content

Rename Zip::apply to for_each including other apply methods#894

Merged
bluss merged 2 commits intomasterfrom
zip-apply-renamed-to-for-each
Jan 15, 2021
Merged

Rename Zip::apply to for_each including other apply methods#894
bluss merged 2 commits intomasterfrom
zip-apply-renamed-to-for-each

Conversation

@bluss
Copy link
Member
@bluss bluss commented Jan 15, 2021

As mentioned in #858. Use the name Zip::for_each which is more idiomatic than apply.
Users of the azip macro are unaffected.

Renames the following and deprecates the old name:

  • apply to for_each
  • apply_collect to map_collect
  • apply_assign_into to map_assign_into
  • par_apply to par_for_each
  • par_apply_collect to par_map_collect
  • par_apply_assign_into to par_map_assign_into

@bluss bluss merged commit 50573f8 into master Jan 15, 2021
@bluss bluss deleted the zip-apply-renamed-to-for-each branch January 15, 2021 16:12
@SparrowLii
Copy link
Contributor
SparrowLii commented Jan 30, 2021

@bluss The function calls in benches does not seem to be changed. Is there some hindrance?

@bluss
Copy link
Member Author
bluss commented Jan 30, 2021

I just forgot to update those - and then I noticed and forgot again, so it just needs to be fixed to use the new name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0