Remove alignment restriction on RawArrayView/Mut#738
Merged
bluss merged 1 commit intorust-ndarray:masterfrom Oct 10, 2019
Merged
Remove alignment restriction on RawArrayView/Mut#738bluss merged 1 commit intorust-ndarray:masterfrom
bluss merged 1 commit intorust-ndarray:masterfrom
Conversation
Member
|
Thanks a lot. I patched it to use |
Member
|
I don't see it as a breaking change, this refinement of detail seems reasonable. |
Member
Author
|
Okay, sounds good. Thanks for fixing up the PR for Rust 1.37. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
.cast()safe without a check for alignment.This might be a breaking change because we documented that
RawArrayView/Muthad alignment requirements. I suppose it depends on how that statement could be interpreted. Someone could think that it would mean that, given anyRawArrayView, it would be safe to call.deref_into_view()without ensuring that the pointer was aligned. IMO, though, since we didn't say exactly what the alignment restrictions were, no one should have made that assumption.