8000 Stack and concatenate by andrei-papou · Pull Request #735 · rust-ndarray/ndarray · GitHub
[go: up one dir, main page]
Skip to content

Stack and concatenate #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Stack and concatenate #735

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b39a0bb
Merge pull request #1 from rust-ndarray/master
Apr 3, 2019
efd686d
Merge pull request #5 from rust-ndarray/master
May 15, 2019
8cd5d5a
Merge pull request #8 from rust-ndarray/master
May 31, 2019
0e9d65d
Merge pull request #9 from rust-ndarray/master
Oct 1, 2019
6525f6e
Renamed `stack` to `concatenate` and added numpy-compliant `stack`
Oct 1, 2019
2d04320
Rustfmt fixes
Oct 1, 2019
ced7ed9
Commit changelog:
Oct 16, 2019
443fa86
Merge pull request #10 from rust-ndarray/master
Oct 16, 2019
68f0e95
Rustfmt fixes
Oct 17, 2019
d997c18
Changelog:
Dec 18, 2019
8e12f82
Changelog:
Dec 18, 2019
8000
ef3d5b6
Merge pull request #11 from rust-ndarray/master
Dec 18, 2019
1e91fe4
Merge branch 'master' of github.com:andrei-papou/ndarray into stack-a…
Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rustfmt fixes
  • Loading branch information
andrei.papou committed Oct 17, 2019
commit 68f0e95a2f33d46a3c3726a0fac5ec2b95ffe75d
3 changes: 2 additions & 1 deletion src/stacking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ where
}
let mut res = Array::from_shape_vec(res_dim, v)?;

res.axis_iter_mut(axis).zip(arrays.into_iter())
res.axis_iter_mut(axis)
.zip(arrays.into_iter())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this zip seems to show that we would be fine with just using a slice of ArrayView as input, we don't need to use them by value

.for_each(|(mut assign_view, array)| {
assign_view.assign(&array);
});
Expand Down
0