8000 Add .nrows(), .ncols() and old names .rows(), .cols() are now deprecated by bluss · Pull Request #701 · rust-ndarray/ndarray · GitHub
[go: up one dir, main page]

Skip to content

Add .nrows(), .ncols() and old names .rows(), .cols() are now deprecated#701

Merged
bluss merged 3 commits intomasterfrom
rows-cols
Sep 8, 2019
Merged

Add .nrows(), .ncols() and old names .rows(), .cols() are now deprecated#701
bluss merged 3 commits intomasterfrom
rows-cols

Conversation

@bluss
Copy link
Member
@bluss bluss commented Sep 8, 2019

.rows()/.cols() are renamed to nrows/ncols respectively, to make space
for putting the row iterable/ndproducer in this place instead.

The deprecated methods will be removed in the release after they were
first deprecated.

These new names and the deprecations are the first step towards renaming genrows/gencolumns #698

…ated

.rows()/.cols() are renamed to nrows/ncols respectively, to make space
for putting the row iterable/ndproducer in this place instead.

The deprecated methods will be removed in the release after they were
first deprecated.
@bluss bluss changed the title Add .nrows(), .ncols() and old names .rows(), .cols() are deprecated Add .nrows(), .ncols() and old names .rows(), .cols() are now deprecated Sep 8, 2019
examples/life.rs Outdated
fn turn_on_corners(z: &mut Board) {
let n = z.rows();
let n = z.nrows();
let m = z.cols();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cols call escaped your purge @bluss 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that one and another instance I found.

@bluss
Copy link
Member Author
bluss commented Sep 8, 2019

🌟 teamwork 🥇 Thanks!

@bluss bluss merged commit e56ca71 into master Sep 8, 2019
@bluss bluss deleted the rows-cols branch September 8, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0