rename into_slice on ArrayView to_slice #646
Merged
LukeMathWalker merged 4 commits intorust-ndarray:masterfrom Jul 4, 2019
Merged
rename into_slice on ArrayView to_slice #646LukeMathWalker merged 4 commits intorust-ndarray:masterfrom
into_slice on ArrayView to_slice #646LukeMathWalker merged 4 commits intorust-ndarray:masterfrom
Conversation
Contributor
Author
|
Gentle reminder on this |
Member
|
I am currently out of the country to RustLab - I will try to set aside some time to go through your issues and PRs next week. But I am also relocating, so be patient with me :) |
Member
|
One minor comment - once it's fixed we can move ahead and merge @max-sixty |
max-sixty
commented
Jul 2, 2019
Contributor
Author
|
Great, added! |
max-sixty
commented
Jul 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid sugge
2EC7
stion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated the existing method
from #642 (comment)