Fix slice offset computation for special cases#636
Merged
jturner314 merged 1 commit intorust-ndarray:masterfrom May 30, 2019
Merged
Fix slice offset computation for special cases#636jturner314 merged 1 commit intorust-ndarray:masterfrom
jturner314 merged 1 commit intorust-ndarray:masterfrom
Conversation
With the old implementation, this resulted in undefined behavior in release mode and a panic in debug mode: ```rust let mut arr = Array2::<i32>::zeros((5, 5)); arr.slice_axis_inplace(Axis(0), Slice::new(0, Some(0), -1)); ``` as did this: ```rust let mut arr = Array2::from_shape_vec((1, 1).strides((10, 1)), vec![5]).unwrap(); arr.slice_axis_inplace(Axis(0), Slice::new(1, Some(1), 1)); ``` Now, both examples operate correctly.
LukeMathWalker
approved these changes
May 12, 2019
Member
There was a problem hiding this comment.
The change looks good and all the rationale is in the comments (plus we have a test to check for regressions). Happy to merge 👍
Member
Author
|
Thanks for reviewing this @LukeMathWalker! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the old implementation, this resulted in undefined behavior in release mode and a panic in debug mode:
as did this:
Now, both examples operate correctly.