8000 Implement approx traits for ArrayBase by jturner314 · Pull Request #581 · rust-ndarray/ndarray · GitHub
[go: up one dir, main page]

Skip to content

Implement approx traits for ArrayBase #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 5, 2019
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
984cf22
Implement approx traits for ArrayBase
jturner314 Jan 11, 2019
d06b935
Feature-gate approx trait implementations
jturner314 Jan 14, 2019
966809a
Merge branch 'master' into update-approx
LukeMathWalker May 4, 2019
cbb07a4
Use Zip::all where possible
LukeMathWalker May 4, 2019
d21fe5c
Mark `all_close` as deprecated
LukeMathWalker May 4, 2019
5e30924
Fix implementation.
LukeMathWalker May 4, 2019
fa60376
Fix issues with conditional execution based on activated features
LukeMathWalker May 4, 2019
8fb8aa4
Remove all_close from all doc tests
LukeMathWalker May 4, 2019
3e47c5c
Update guide for NumPy users
LukeMathWalker May 4, 2019
9b83175
Replace all_close with abs_diff_eq in tests (currently failing)
LukeMathWalker May 4, 2019
e0f390d
Fix typo, pin 0.3.2 to get latest changes
LukeMathWalker May 4, 2019
ac67ea5
Allow comparison between arrays with different ownership properties
LukeMathWalker May 5, 2019
35915b8
Fix assertions
LukeMathWalker May 5, 2019
3d81967
Fix test
LukeMathWalker May 5, 2019
cf646e2
Move tests from all_close to approx
LukeMathWalker May 5, 2019
e6c6ff1
Move tests from all_close to approx
LukeMathWalker May 5, 2019
15122f2
Merge pull request #2 from LukeMathWalker/update-approx
jturner314 May 5, 2019
80488fd
Merge branch 'master' into approx
LukeMathWalker May 5, 2019
9f9aeba
Impl approx traits for differing element types
jturner314 May 5, 2019
54a6895
Fix unused import warning
jturner314 May 5, 2019
bdb2b86
Remove duplicate type parameter
jturner314 May 5, 2019
e3b2b97
Merge branch 'master' into approx
jturner314 May 5, 2019
a2070aa
Fix link in docs
jturner314 May 5, 2019
3219842
Fix tests
jturner314 May 5, 2019
3d89f7d
Fix formatting
jturner314 May 5, 2019
e7ea7f3
Remove unnecessary &
jturner314 May 5, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace all_close with abs_diff_eq in tests (currently failing)
  • Loading branch information
LukeMathWalker committed May 4, 2019
commit 9b831753a74f3bef35cca07789e1749e47e71ccd
15 changes: 9 additions & 6 deletions tests/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use ndarray::{
multislice,
};
use ndarray::indices;
use approx::AbsDiffEq;
use defmac::defmac;
use itertools::{enumerate, zip, Itertools};

Expand Down Expand Up @@ -680,15 +681,16 @@ fn test_sub_oob_1() {


#[test]
#[cfg(feature = "approx")]
fn test_select(){
// test for 2-d array
let x = arr2(&[[0., 1.], [1.,0.],[1.,0.],[1.,0.],[1.,0.],[0., 1.],[0., 1.]]);
let r = x.select(Axis(0),&[1,3,5]);
let c = x.select(Axis(1),&[1]);
let r_target = arr2(&[[1.,0.],[1.,0.],[0., 1.]]);
let c_target = arr2(&[[1.,0.,0.,0.,0., 1., 1.]]);
assert!(r.all_close(&r_target,1e-8));
assert!(c.all_close(&c_target.t(),1e-8));
assert!(r.abs_diff_eq(&r_target,1e-8));
assert!(c.abs_diff_eq(&c_target.t(),1e-8));

// test for 3-d array
let y = arr3(&[[[1., 2., 3.],
Expand All @@ -699,8 +701,8 @@ fn test_select(){
let c = y.select(Axis(2),&[1]);
let r_target = arr3(&[[[1.5, 1.5, 3.]], [[1., 2.5, 3.]]]);
let c_target = arr3(&[[[2.],[1.5]],[[2.],[2.5]]]);
assert!(r.all_close(&r_target,1e-8));
assert!(c.all_close(&c_target,1e-8));
assert!(r.abs_diff_eq(&r_target,1e-8));
assert!(c.abs_diff_eq(&c_target,1e-8));

}

Expand Down Expand Up @@ -1733,13 +1735,14 @@ fn test_contiguous() {
}

#[test]
#[cfg(feature = "approx")]
fn test_all_close() {
let c = arr3(&[[[1., 2., 3.],
[1.5, 1.5, 3.]],
[[1., 2., 3.],
[1., 2.5, 3.]]]);
assert!(c.all_close(&aview1(&[1., 2., 3.]), 1.));
assert!(!c.all_close(&aview1(&[1., 2., 3.]), 0.1));
assert!(c.abs_diff_eq(&aview1(&[1., 2., 3.]), 1.));
assert!(c.abs_diff_neq(&aview1(&[1., 2., 3.]), 0.1));
}

#[test]
Expand Down
0