10000 Add partition(similar to numpy.partition) by NewBornRustacean · Pull Request #1498 · rust-ndarray/ndarray · GitHub
[go: up one dir, main page]
Skip to content

Add partition(similar to numpy.partition) #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 6, 2025
Merged

Add partition(similar to numpy.partition) #1498

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b800bec
fn partition, first draft
NewBornRustacean Mar 27, 2025
df59179
handle non-contiguous with create and copy back
NewBornRustacean Mar 28, 2025
8034819
Merge branch 'master' into feature-add-numpy-like-partition
NewBornRustacean Mar 30, 2025
8f72117
include review: not to allocate n-vector, reuse a single vector
NewBornRustacean Apr 3, 2025
a0df066
format nightly
NewBornRustacean Apr 3, 2025
3344cf8
applied feedback: safe unwrap(), avoid navie iter()
NewBornRustacean Apr 4, 2025
05dee0e
initialize temp vector in advance
NewBornRustacean Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
applied feedback: safe unwrap(), avoid navie iter()
  • Loading branch information
@NewBornRustacean
NewBornRustacean committed Apr 4, 2025
commit 3344cf8b73fe8c5760d3c0cbdad31f5b52078722
12 changes: 8 additions & 4 deletions src/impl_methods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3218,7 +3218,7 @@ impl<A, D: Dimension> ArrayRef<A, D>
/// ```
pub fn partition(&self, kth: usize, axis: Axis) -> Array<A, D>
where
A: Clone + Ord,
A: Clone + Ord + num_traits::Zero,
D: Dimension,
{
// Bounds checking
Expand All @@ -3234,8 +3234,8 @@ impl<A, D: Dimension> ArrayRef<A, D>
.lanes_mut(axis)
.into_iter()
.next()
.map(|lane| lane.is_contiguous())
.unwrap_or(false);
.unwrap()
.is_contiguous();

if is_contiguous {
Zip::from(result.lanes_mut(axis)).for_each(|mut lane| {
Expand All @@ -3246,7 +3246,11 @@ impl<A, D: Dimension> ArrayRef<A, D>

Zip::from(result.lanes_mut(axis)).for_each(|mut lane| {
temp_vec.clear();
temp_vec.extend(lane.iter().cloned());
temp_vec.resize(axis_len, A::zero());

Zip::from(&mut temp_vec).and(&lane).for_each(|dest, src| {
*dest = src.clone();
});

temp_vec.select_nth_unstable(kth);

Expand Down
Loading
0