Allow macro ndarray::s! in no_std.#1154
Merged
jturner314 merged 3 commits intorust-ndarray:masterfrom Mar 2, 2022
Merged
Conversation
|
Hi @bluss. Do you know when you may have time to look into this PR? It's starting to block us in icu4x. |
jturner314
reviewed
Feb 25, 2022
jturner314
reviewed
Feb 25, 2022
Member
There was a problem hiding this comment.
I added a couple of comments -- I think some of the changes are unnecessary. AFAIK, the only necessary change is changing ::std to ::core in the macro.
Member
|
Thanks! |
|
@jturner314 woudl it be possible to get a release with this fix? |
|
Hey @jturner314! Do you think you could release an update to |
jturner314
pushed a commit
to jturner314/ndarray
that referenced
this pull request
Jul 30, 2022
Merged
jturner314
pushed a commit
that referenced
this pull request
Jul 30, 2022
Member
|
@makotokato, @zbraniecki, @Manishearth, @sffc I've released version 0.15.5, which includes this change. @makotokato Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use
ndarray::s!in no_std, but I would like to use it even if no_std.