E536 Improve layout heuristic for sum_axis by jturner314 · Pull Request #1061 · rust-ndarray/ndarray · GitHub
[go: up one dir, main page]

Skip to content

Improve layout heuristic for sum_axis#1061

Merged
bluss merged 1 commit intorust-ndarray:masterfrom
jturner314:faster-sum_axis
Oct 25, 2021
Merged

Improve layout heuristic for sum_axis#1061
bluss merged 1 commit intorust-ndarray:masterfrom
jturner314:faster-sum_axis

Conversation

@jturner314
Copy link
Member

This is an attempt to fix #1058. It would be nice to have some benchmarks to confirm that this is an improvement, but I haven't gotten a chance to write them.

Copy link
Member
@bluss bluss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, an improvement in style of implementation too (level of abstraction etc).

@jturner314 jturner314 marked this pull request as ready for review September 3, 2021 17:51
@bluss bluss added this to the 0.15.4 milestone Oct 25, 2021
@bluss bluss merged commit abfdf4d into rust-ndarray:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sum_axis very slow when summing on last axis

2 participants

0