-
Notifications
You must be signed in to change notification settings - Fork 305
added 8000 lychee config and workflow, fixes #718, fixes #722 #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fixed xtask exit code
fixed link error in intro (about.md)
Should now work with github cache, requires access to prs to submit comments (e.g.: Arteiii#5 (comment)) Fixed some broken links, others require src update as they broke due to breaking changes in the crate (#719) |
- CONTRIBUTING.md (removed link as its not required and no longer available) - src/encoding/string/url-encode.md (updated form_urlencoded is not a part of url its re-exported) - README.md (removed travis CI link [404](https://www.travis-ci.com/rust-lang-nursery/rust-cookbook)) - src/development_tools/debugging/config_log/log-custom.md (log4rs::config::Config is a re-export from log4rs::config::runtime::Config) - src/web/scraping/broken.md (tokio::spawn to tokio::task::spawn) - src/web/clients/api/rate-limited.md (removed file rust src broken links broken and is not used or displayed on the current cookbook build) - src/cryptography/hashing/hmac.md (updated description, added tag type hint, and updated links)
using workflow by https://github.com/innoq/action-cargo-test-report
testing workflow also works now creates a junit report based on this project: example pr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ready to merge it. It is hard to review without the updated example, but overall this is a big improvement.
CONTRIBUTING.md
(removed link as its not required and no longer available)src/encoding/string/url-encode.md
(updated form_urlencoded is not a part of url its re-exported)README.md
(removed travis CI link 404)src/development_tools/debugging/config_log/log-custom.md
(log4rs::config::Config is a re-export from log4rs::config::runtime::Config)src/web/scraping/broken.md
(tokio::spawn to tokio::task::spawn)src/web/clients/api/rate-limited.md
(removed file rust src is broken and also broken links and is not used or displayed on the current cookbook build)src/cryptography/hashing/hmac.md
(updated description, added tag type hint, and updated links)