Added support for testing the backend with abi-cafe #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could also add it to CI. Takes about 5min for cg_clif when only testing Linux. For handling the known test failures, there is a section in |
|
Getting this to run reliably in the CI is proving a bit difficult. Could we get this PR merged for now, and worry about adding new checks to the CI later? |
|
I'm good with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new command(abi-test) that runs the abi-cafe test suite, comparing the ABI implemented by the LLVM version of Rustc, and the GCC version of rustc.
Additionally, as a base sanity check, the command will also compare the implementation of the C abi in cg_gcc and in the system's C compiler.