8000 `filter_next`: check for `filter().next_back()` by zihan0822 · Pull Request #15748 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]
Skip to content

filter_next: check for filter().next_back() #15748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

filter_next: check for filter().next_back() #15748

merged 1 commit into from
Sep 26, 2025

Conversation

zihan0822
Copy link
Contributor
@zihan0822 zihan0822 commented Sep 23, 2025 •
edited by rustbot
Loading

Closes: #15715

changelog: [filter_next]: suggest replacing filter().next_back() with rfind() for DoubleEndedIterator

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
@rustbot
Copy link
Collaborator
rustbot commented Sep 23, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Jarcho
Jarcho requested changes Sep 25, 2025
View reviewed changes
Copy link
Contributor
@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an MSRV check. rfind was added in 1.27.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 25, 2025
@zihan0822
filter_next: check for filter().next_back()
5619465 
changelog: [`filter_next`]: suggest replacing `filter().next_back()` with
`rfind()` for `DoubleEndedIterator`

Signed-off-by: Zihan <zihanli0822@gmail.com>
@zihan0822 zihan0822 force-pushed the filter-next-back-to-rfind branch from d5a2670 to 5619465 Compare September 25, 2025 13:27
@zihan0822 zihan0822 requested a review from Jarcho September 25, 2025 13:39
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 25, 2025
Jarcho
Jarcho approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor
@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

View changes since this review

@Jarcho Jarcho added this pull request to the merge queue Sep 26, 2025
Merged via the queue into rust-lang:master with commit abdc61f Sep 26, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest replacing .filter(p).next_back() with .rfind(p).
3 participants
@zihan0822 @rustbot @Jarcho
0