8000 fix(ref_option): don't lint in external and proc-macros by ada4a · Pull Request #15668 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]
Skip to content

fix(ref_option): don't lint in external and proc-macros #15668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2025
Merged

fix(ref_option): don't lint in external and proc-macros #15668

merged 2 commits into from
Sep 13, 2025
+481 −381

Conversation

ada4a
Copy link
Contributor
@ada4a ada4a commented Sep 13, 2025

Fixes #14063

changelog: [ref_option]: don't lint in external and proc-macros

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2025
@rustbot
Copy link
Collaborator
rustbot commented Sep 13, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

samueltardieu
samueltardieu requested changes Sep 13, 2025
View reviewed changes
Copy link
Member
@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nit.

There is also a typo at the end of the first commit message ("trais" instead of "traits").

r? samueltardieu @rustbot author

View changes since this review

@rustbot rustbot assigned samueltardieu and unassigned y21 Sep 13, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 13, 2025
@rustbot
Copy link
Collaborator
rustbot commented Sep 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ada4a
clean-up
25cf36a 
- move tests to `ui-toml/`, since they all use `clippy.toml`
- remove the trait test case from `ref_option.rs`, because it's already
  covered by `ref_option_traits.rs`
@ada4a
fix(ref_option): don't lint in external and proc-macros
b901ba7
@ada4a
Copy link
Contributor Author
ada4a commented Sep 13, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 13, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Sep 13, 2025
Merged via the queue into rust-lang:master with commit 472768a Sep 13, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2025
@ada4a ada4a deleted the ref_option branch September 13, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contents of expanded derive macro are being checked and errors generated
4 participants
@ada4a @rustbot @samueltardieu @y21
0