8000 fix(multiple_unsafe_ops_per_block): ignore unsafe ops from `.await` desugaring by ada4a · Pull Request #15654 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]

Skip to content

Conversation

ada4a
Copy link
Contributor
ada4a commented Sep 10, 2025

Fixes #13879

changelog: [multiple_unsafe_ops_per_block]: ignore unsafe ops from .await desugaring

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 10, 2025
@rustbot
Copy link
Collaborator
rustbot commented Sep 10, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member
@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a nit in the tests.

r? samueltardieu @rustbot author

View changes since this review

#![allow(clippy::unnecessary_operation)]
#![allow(dropping_copy_types)]
#![allow(clippy::assign_op_pattern)]
#![expect(unused, clippy::unnecessary_operation, dropping_copy_types)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to expect the unused lint, it just happens or not, we want to allow it. Moreover, it is allowed already in our tests, and can be removed entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you're right. Removed it, thanks:)

@rustbot rustbot assigned samueltardieu and unassigned blyxyas Sep 12, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 12, 2025
@rustbot
Copy link
Collaborator
rustbot commented Sep 12, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ada4a ada4a force-pushed the multiple_unsafe_ops_per_block branch from 7dd5634 to da6d23b Compare September 12, 2025 16:23
@ada4a
Copy link
Contributor Author
ada4a commented Sep 12, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 12, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Sep 14, 2025
Merged via the queue into rust-lang:master with commit cb286b4 Sep 14, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 14, 2025
@ada4a ada4a deleted the multiple_unsafe_ops_per_block branch September 14, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiple_unsafe_ops_per_block false positive when future is awaited inside unsafe block

4 participants

0