8000 Check for proc macros from within `explicit_deref_methods` and do not lint on proc macro expansions by JustusFluegel · Pull Request #15628 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]
Skip to content

Check for proc macros from within explicit_deref_methods and do not lint on proc macro expansions #15628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

Check for proc macros from within explicit_deref_methods and do not lint on proc macro expansions #15628

merged 2 commits into from
Sep 23, 2025
+52 −14

Conversation

JustusFluegel
Copy link
Contributor
@JustusFluegel JustusFluegel commented Sep 7, 2025 •
edited by rustbot
Loading

Adds a is_from_proc_macro(...,...) check to the explicit_deref_methods lint.

Note that this is my first contribution to clippy and i am not 100% sure that this is how such bugs are intended to be fixed, so please be kind with any feedback, I appreciate that a lot! Thanks!

changelog: [explicit_deref_methods]: no longer triggers from within proc macro expansions

fixes #15168

@rustbot
Copy link
Collaborator
rustbot commented Sep 7, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 7, 2025
@rustbot

This comment has been minimized.

Sign in to view
@JustusFluegel
Fix explicit_deref_methods triggering from within proc macros
e513ecc 
Signed-off-by: Justus Flügel <justusfluegel@gmail.com>
@rustbot
Copy link
Collaborator
rustbot commented Sep 12, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JustusFluegel
Copy link
Contributor Author
JustusFluegel commented Sep 12, 2025 •
edited
Loading

I rebased ontop of latest main master at the time of writing :)

samueltardieu
samueltardieu reviewed Sep 12, 2025
View reviewed changes
samueltardieu
samueltardieu reviewed Sep 12, 2025
View reviewed changes
samueltardieu
samueltardieu reviewed Sep 12, 2025
View reviewed changes
@JustusFluegel
Copy link
Contributor Author

Sorry it took a while but finally got around to adding the comment. If anyone has any further review comments, they are very welcome :)

@JustusFluegel
Add tests for explicit_deref_methods lints from within proc macros
3e65620 
Signed-off-by: Justus Flügel <justusfluegel@gmail.com>
Alexendoo
Alexendoo approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member
@Alexendoo Alexendoo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@Alexendoo Alexendoo added this pull request to the merge queue Sep 23, 2025
Merged via the queue into rust-lang:master with commit af0bc98 Sep 23, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

explicit_deref_methods triggering from within macros

4 participants

@JustusFluegel @rustbot @samueltardieu @Alexendoo
0