10000 fix `nonstandard_macro_braces`: suggest trailing semicolon when needed by ada4a · Pull Request #15593 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]
Skip to content

fix nonstandard_macro_braces: suggest trailing semicolon when needed #15593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

fix nonstandard_macro_braces: suggest trailing semicolon when needed #15593

merged 1 commit into from
Sep 19, 2025

Conversation

ada4a
Copy link
Contributor
@ada4a ada4a commented Aug 30, 2025

Fixes #9913

changelog: [nonstandard_macro_braces]: suggest trailing semicolon when needed

@rustbot
Copy link
Collaborator
rustbot commented Aug 30, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 30, 2025
@ada4a ada4a force-pushed the nonstandard_macro_braces branch from f0cb9fb to 0234675 Compare September 2, 2025 08:40
blyxyas
blyxyas requested changes Sep 13, 2025
View reviewed changes
Copy link
Member
@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great looking contribution! Just a couple maintanability requests, but everything should be smooth sailing from here =^w^=

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 13, 2025
@ada4a ada4a force-pushed the nonstandard_macro_braces branch from 0234675 to b92330b Compare September 14, 2025 08:30
@rustbot
Copy link
Collaborator
rustbot commented Sep 14, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author
ada4a commented Sep 14, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 14, 2025
blyxyas
blyxyas approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member
@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great bugfix!!

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Sep 19, 2025
@ada4a
8000 Copy link
Contributor Author
ada4a commented Sep 19, 2025

Thank you @blyxyas :)

Merged via the queue into rust-lang:master with commit cc5a01d Sep 19, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 19, 2025
@ada4a ada4a deleted the nonstandard_macro_braces branch September 19, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP nonstandard_macro_braces with println{} and successive code
3 participants
@ada4a @rustbot @blyxyas
0