fix unnecessary_semicolon: FN on #[feature(stmt_expr_attributes)]
#15481
Conversation
1e0155e to
a8320b3
Compare
|
@ada4a is there a reason why you closed this, or are you just over-capacity and this one wasn't that high up in the list of priorities? =^w^= |
|
Oops, thanks for letting me know -- I just messed up this particular branch when rebasing all the bajillion of them that I have onto the latest master (for the rust sync). Reopened it^^ |
a8320b3 to
2aff1b7
Compare
|
Hmmm weird, the |
There was a problem hiding this comment.
LGTM, thanks! ❤️
I'll mark this as blocked to be reviewed after the feature freeze, because it still creates a new environment for things to fail, but thanks a lot for the fix. When the feature freeze is over, I'll merge it.
@rustbot blocked
@rustbot note Feature freeze
@rustbot label +C-enhancement
|
|
||
| fn main() { | ||
| // removing the `;` would turn the stmt into an expr, but attrs aren't allowed on exprs | ||
| // -- but not with the feature enabled |
There was a problem hiding this comment.
This wording is a bit strange
| // -- but not with the feature enabled | |
| // unless the feature `stmt_expr_attributes` is enabled |
2aff1b7 to
6992a8e
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
6992a8e to
27cad5a
Compare
|
@rustbot ready |
inspired by #15476
changelog: [
unnecessary_semicolon]: FN on#[feature(stmt_expr_attributes)]Summary Notes
Managed by
@rustbot—see help for details