8000 Note that using `enumerate()` will swap the arguments by samueltardieu · Pull Request #14969 · rust-lang/rust-clippy · GitHub
[go: up one dir, main page]
Skip to content

Note that using enumerate() will swap the arguments #14969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Note that using enumerate() will swap the arguments #14969

merged 1 commit into from
Sep 19, 2025
+172 −15

Conversation

samueltardieu
Copy link
Member
@samueltardieu samueltardieu commented Jun 4, 2025 •
edited by rustbot
Loading

The autofix now:

  • includes the swapping of index and element in the closure in which the content will be consumed;
  • notes, with applicability MaybeIncorrect (because it will be), that the element and the index will be swapped.

changelog: [range_zip_with_len]: better suggestion, and better applicability

Fixes #14929

@rustbot
Copy link
Collaborator
rustbot commented Jun 4, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 4, 2025
@samueltardieu
Note that using enumerate() will swap the arguments
ea2ea62 
The autofix now:

- includes the swapping of index and element in the closure in which the
  content will be consumed;
- notes, with applicability `MaybeIncorrect` (because it will be), that
  the element and the index will be swapped.
@samueltardieu
Copy link
Member Author

r? clippy

@rustbot rustbot assigned Centri3 and unassigned Alexendoo Jul 28, 2025
@samueltardieu
Copy link
Member Author

r? clippy

@rustbot rustbot assigned blyxyas and unassigned Centri3 Sep 14, 2025
blyxyas
blyxyas approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member
@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution and have a great day! ❤️

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Sep 19, 2025
Merged via the queue into rust-lang:master with commit c2325dc Sep 19, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 19, 2025
@samueltardieu samueltardieu deleted the issue-14929 branch September 19, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

range_zip_with_len causes type mismatch

5 participants

@samueltardieu @rustbot @blyxyas @Alexendoo @Centri3
0