8000 Fix not applicable on trailing comma for remove_dbg by A4-Tacks · Pull Request #20714 · rust-lang/rust-analyzer · GitHub
[go: up one dir, main page]
Skip to content

Fix not applicable on trailing comma for remove_dbg #20714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2025
Merged

Fix not applicable on trailing comma for remove_dbg #20714

merged 1 commit into from
Sep 21, 2025

Conversation

A4-Tacks
Copy link
Contributor

remove_dbg not applicable for whitespaces after trailing comma

Example

fn foo() {
    dbg!(
        bar(),
    );
}

Before this PR:

Assist not applicable

After this PR:

fn foo() {
    bar();
}

@A4-Tacks
Fix not applicable on trailing comma for remove_dbg
168ca55 
`remove_dbg` not applicable for whitespaces after trailing comma

Example
---
```rust
fn foo() {
    dbg!(
        bar(),
    );
}
```

**Before this PR**:

Assist not applicable

**After this PR**:

```rust
fn foo() {
    bar();
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2025
ShoyuVanilla
ShoyuVanilla approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member
@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Sep 21, 2025
Merged via the queue into rust-lang:master with commit e7d7cb4 Sep 21, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2025
@A4-Tacks A4-Tacks deleted the rm-dbg-trailing-comma branch September 21, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A4-Tacks @ShoyuVanilla @rustbot
0