8000 fix negative const generic integer literals by Oblarg · Pull Request #20697 · rust-lang/rust-analyzer · GitHub
[go: up one dir, main page]
Skip to content

fix negative const generic integer literals #20697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

fix negative const generic integer literals #20697

merged 2 commits into from
Sep 19, 2025

Conversation

Oblarg
Copy link
@Oblarg Oblarg commented Sep 18, 2025

#20696

openly admit this was AI-assisted, but it seemed like a sufficiently small/straightforward issue to be a good idea to attempt

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2025
@Oblarg Oblarg force-pushed the fix-negative-const-generic-literals branch 2 times, most recently from 900c394 to bdfa88a Compare September 18, 2025 22:52
@Oblarg Oblarg force-pushed the fix-negative-const-generic-literals branch from bdfa88a to d0bdedd Compare September 18, 2025 22:55
ShoyuVanilla
ShoyuVanilla approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member
@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should eventually lower const generics with consteval for the bigger picture. That said, this PR doesn’t cause any harm—it introduces some improvements with only small changes. Approving with a nit

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Sep 19, 2025
Merged via the queue into rust-lang:master with commit 2c6f0fc Sep 19, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2025
@lnicola
Copy link
Member
lnicola commented Sep 30, 2025

changelog fix (first contribution) fix negative literals in const generics

@lnicola lnicola mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oblarg @lnicola @ShoyuVanilla @rustbot
0