E52C fix: add `else` keyword completion after `let` statements by A4-Tacks · Pull Request #20620 · rust-lang/rust-analyzer · GitHub
[go: up one dir, main page]
Skip to content

fix: add else keyword completion after let statements #20620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

fix: add else keyword completion after let statements #20620

merged 1 commit into from
Sep 8, 2025

Conversation

A4-Tacks
Copy link
Contributor
@A4-Tacks A4-Tacks commented Sep 6, 2025 •
edited
Loading

Example

fn foo() {
    let _ = 2 el$0
}

->

fn foo() {
    let _ = 2 else {
        $0
    };
}

And fix the no completion semicolon for else in incomplete LetStmt of #20518

fn foo() {
    let _ = if true {} el$0
}

Before this PR:

fn foo() {
    let _ = if true {} else {
        $0
    }
}

After this PR:

fn foo() {
    let _ = if true {} else {
        $0
    };
}

@A4-Tacks
Add allow else keyword completion in LetStmt
56114fc 
Example
---
```rust
fn foo() {
    let _ = 2 el$0
}
```
->
```rust
fn foo() {
    let _ = 2 else {
        $0
    };
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2025
@A4-Tacks A4-Tacks mentioned this pull request Sep 6, 2025
Open
@lnicola lnicola changed the title Add allow else keyword completion in LetStmt fix: add else keyword completion after let statements Sep 8, 2025
@lnicola lnicola added this pull request to the merge queue Sep 8, 2025
Merged via the queue into rust-lang:master with commit a91fb2b Sep 8, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2025
@A4-Tacks A4-Tacks deleted the let-else-completion branch September 9, 2025 07:39
@lnicola lnicola mentioned this pull request Sep 13, 2025
Merged
@A4-Tacks
Copy link
Contributor Author

Closed as completed for #20620

@A4-Tacks
Copy link
Contributor Author

Sorry, I mistook this for an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A4-Tacks @lnicola @rustbot
0