next-solver fun time #20446
Merged
next-solver fun time #20446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd9a279 to
719ee8e
Compare
lcnr
commented
Aug 13, 2025
| let infer_ctxt = interner.infer_ctxt().build(TypingMode::non_body_analysis()); | ||
| let infer_ctxt = interner.infer_ctxt().build(TypingMode::PostAnalysis); | ||
| let cause = ObligationCause::dummy(); | ||
| let ty = deeply_normalize(infer_ctxt.at(&cause, ParamEnv::empty()), ty).unwrap_or(ty); |
There was a problem hiding this comment.
opaque types should just be normalized like any other alias. For this to work, computing the layout uses TypingMode::PostAnalysis which then fetches the underlying type for all opaques in the program
38ba69e to
425d68f
Compare
Veykril
approved these changes
Aug 13, 2025
|
Thanks! |
|
changelog fixup #20329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix the metrics issue for hyper, unless there's also another issue here 🤔