10000 revert #75443, update mir validator by lcnr · Pull Request #78410 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

revert #75443, update mir validator #78410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2020
Merged

revert #75443, update mir validator #78410

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc19df6
revert #75443 update mir validator
lcnr Oct 26, 2020
e06785b
improve fixme
lcnr Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve fixme
  • Loading branch information
@lcnr
lcnr committed Nov 6, 2020
commit e06785b676bb639fef071feca302432c61fbddcc
9 changes: 6 additions & 3 deletions compiler/rustc_mir/src/transform/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,12 @@ pub fn equal_up_to_regions(
param_env,
ty.fold_with(&mut BottomUpFolder {
tcx,
// We just erase all late-bound lifetimes, but this is not fully correct (FIXME):
// lifetimes in invariant positions could matter (e.g. through associated types).
// We rely on the fact that layout was confirmed to be equal above.
// FIXME: We erase all late-bound lifetimes, but this is not fully correct.
// If you have a type like `<for<'a> fn(&'a u32) as SomeTrait>::Assoc`,
// this is not necessarily equivalent to `<fn(&'static u32) as SomeTrait>::Assoc`,
// since one may have an `impl SomeTrait for fn(&32)` and
// `impl SomeTrait for fn(&'static u32)` at the same time which
// specify distinct values for Assoc. (See also #56105)
lt_op: |_| tcx.lifetimes.re_erased,
// Leave consts and types unchanged.
ct_op: |ct| ct,
Expand Down
0