8000 const_evaluatable_checked: deal with unused nodes + div by lcnr · Pull Request #78272 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

const_evaluatable_checked: deal with unused nodes + div #78272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2020
Merged

const_evaluatable_checked: deal with unused nodes + div #78272

merged 2 commits into from
Oct 25, 2020

Conversation

lcnr
Copy link
Contributor
@lcnr lcnr commented Oct 23, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2020
@lcnr lcnr added F-generic_const_exprs `#![feature(generic_const_exprs)]` F-const_generics `#![feature(const_generics)]` labels Oct 23, 2020
oli-obk
oli-obk reviewed Oct 23, 2020
View reviewed changes
oli-obk
oli-obk reviewed Oct 23, 2020
View reviewed changes
compiler/rustc_trait_selection/src/traits/const_evaluatable.rs Outdated
self.error(None, "unused node")?;
}

return Ok(self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use a separate map for metadata not needed for the result, you can use alloc_slice which is cheaper than alloc_from_iter (though that will probably need a method to get a slice from an IndexVec, too)

Copy link
Contributor Author