Self contained linking option #72738
Conversation
|
@petrochenkov could you do |
|
@bors try |
|
⌛ Trying commit b173dca3afcee12951c6df33733197171f5cf0f8 with merge 97f416b9b95c99013190cc71a59bd73d0596ba36... |
|
☀️ Try build successful - checks-azure |
|
Proof of concept detection of external MinGW appears to work nice. FYI:
So to really fix #68887 we have to move the linker to |
|
At first I though this could be landed separately but now I'm not that sure. This PR is already a slight improvement but full potential requires #72999 + another change to also move bin to self-contained directory. |
|
Ok, let's start with #72999 then. |
ec4e7b0 to
a988905
Compare
|
Can I have one more try build to test musl and MinGW? |
|
@bors try |
|
⌛ Trying commit a98890521222b8a209d08db7e3ee68bcf876b503 with merge f90b336e3b94505daa475040dc34722df2ae2b16... |
|
☀️ Try build successful - checks-azure |
9863a28 to
4c5e9f0
Compare
|
That could use one last try. |
|
@bors try |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
|
Needs rebase. |
c1d1617 to
fed5593
Compare
|
@bors try |
|
⌛ Trying commit fed5593fa808a369ea5126cfeb09874c2b687e3f with merge 122b602cd8399434540a6b5932a1938330f66c36... |
|
☀️ Try build successful - checks-azure |
fed5593 to
f2ee031
Compare
|
Looks like this is ready? |
f2ee031 to
f27dcd7
Compare
Yeah, forgot to write a comment 🤷♂️ |
|
@bors r+ |
|
📌 Commit f27dcd7 has been approved by |
…trochenkov Self contained linking option With objects moved to self-contained directory by rust-lang#72999 we can now add option to control whether to use self-contained on native linkage mode.
…arth Rollup of 14 pull requests Successful merges: - rust-lang#72617 (Add a fast path for `std::thread::panicking`.) - rust-lang#72738 (Self contained linking option) - rust-lang#72770 (Implement mixed script confusable lint.) - rust-lang#73418 (Add unstable `core::mem::variant_count` intrinsic) - rust-lang#73460 (Emit line info for generator variants) - rust-lang#73534 (Provide suggestions for some moved value errors) - rust-lang#73538 (make commented examples use valid syntax, and be more consistent ) - rust-lang#73581 (Create 0766 error code) - rust-lang#73619 (Document the mod keyword) - rust-lang#73621 (Document the mut keyword) - rust-lang#73648 (Document the return keyword) - rust-lang#73673 (Fix ptr doc warnings.) - rust-lang#73674 (Tweak binop errors) - rust-lang#73687 (Clean up E0701 explanation) Failed merges: - rust-lang#73708 (Explain move errors that occur due to method calls involving `self` (take two)) r? @ghost
With objects moved to self-contained directory by #72999 we can now add option to control whether to use self-contained on native linkage mode.