8000 Rollup of 5 pull requests by Dylan-DPC-zz · Pull Request #71549 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

Rollup of 5 pull requests #71549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 25, 2020
Merged

Rollup of 5 pull requests #71549

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3eb1c43
Ignore -Zprofile when building compiler_builtins
Amanieu Apr 20, 2020
602f206
Use correct span on while (let) lowering
flip1995 Apr 23, 2020
898cbf2
update_tests
flip1995 Apr 23, 2020
e42337b
Quick and dirty fix of the unused_braces lint
flip1995 Apr 24, 2020
485f199
Add rustdoc regression test for the unused_braces lint
flip1995 Apr 24, 2020
e6cf6a7
Take a single root node in range_search
Mark-Simulacrum Apr 24, 2020
be0e9c2
Revert "Move early needs_subst bailout to _after_ linting."
RalfJung Apr 22, 2020
7d23c3b
adjust tests
RalfJung Apr 22, 2020
cbbf065
Rollup merge of #71364 - Amanieu:zprofile_compiler_builtins, r=cramertj
Dylan-DPC Apr 25, 2020
6ded356
Rollup merge of #71494 - flip1995:while_let_span, r=petrochenkov
Dylan-DPC Apr 25, 2020
4762e22
Rollup merge of #71517 - flip1995:unused_braces_hack, r=oli-obk
Dylan-DPC Apr 25, 2020
62b3624
Rollup merge of #71523 - Mark-Simulacrum:alloc-inline-dup, r=Amanieu
Dylan-DPC Apr 25, 2020
4b5b6cb
Rollup merge of #71533 - pnkfelix:revert-70566-for-const-validation-f…
Dylan-DPC Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Move early needs_subst bailout to _after_ linting." 
This reverts commit 99492e4.
  • Loading branch information
@RalfJung @pnkfelix
RalfJung authored and pnkfelix committed Apr 24, 2020
commit be0e9c2bdc948b806412c70d5769f8341491543c
10 changes: 5 additions & 5 deletions src/librustc_mir/transform/const_pr 8000 op.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,11 @@ impl<'mir, 'tcx> ConstPropagator<'mir, 'tcx> {
return None;
}

// FIXME we need to revisit this for #67176
if rvalue.needs_subst() {
return None;
}

// Perform any special handling for specific Rvalue types.
// Generally, checks here fall into one of two categories:
// 1. Additional checking to provide useful lints to the user
Expand Down Expand Up @@ -636,11 +641,6 @@ impl<'mir, 'tcx> ConstPropagator<'mir, 'tcx> {
_ => {}
}

// FIXME we need to revisit this for #67176
if rvalue.needs_subst() {
return None;
}

self.use_ecx(|this| {
trace!("calling eval_rvalue_into_place(rvalue = {:?}, place = {:?})", rvalue, place);
this.ecx.eval_rvalue_into_place(rvalue, place)?;
Expand Down
0