ty/walk: iterate GenericArgs instead of Tys.
#70164
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm doing a perf run with just commit, to assess the impact of collecting
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 27d6047f0fc787370b110688389204e2c4c57bc6 with merge e8f55d1b486e3355f5cb9b8252d069943e421ac0... |
|
☀️ Try build successful - checks-azure |
|
Queued e8f55d1b486e3355f5cb9b8252d069943e421ac0 with parent f4c675c, future comparison URL. |
|
Finished benchmarking try commit e8f55d1b486e3355f5cb9b8252d06 8000 9943e421ac0, comparison URL. |
|
Looks harmless, I guess? I'll finish the PR assuming the first commit is acceptable. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GenericArgs instead of Tys.GenericArgs instead of Tys.
|
@bors r=nikomatsakis rollup=never (just in case we get another surprise) |
|
📌 Commit 626abc7 has been approved by |
|
@bors p=1 |
|
☀️ Test successful - checks-azure |
|
📣 Toolstate changed by #70164! Tested on commit 209b2be. 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). |
Tested on commit rust-lang/rust@209b2be. Direct link to PR: <rust-lang/rust#70164> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
…r=nikomatsakis outlives: ignore lifetimes shallowly found in `ty::FnDef`s. Fixes rust-lang#70917 by restoring the pre-rust-lang#70164 behavior for now. r? @nikomatsakis
Before this PR,
Ty::walkonly iterated overTys, but that's becoming an increasing problem withconstgenerics, asty::Consts inSubstsare missed by it.By working with
GenericArginstead, we can handle bothTys andty::Consts, but alsoty::Regions, which used to require ad-hoc mechanisms such aspush_regions.I've also removed
TraitRef::input_types, as it's both long obsolete, and easy to misuse.