rustdoc: HTML escape crate version #69598

ollie27 · 2020-02-29T23:47:57Z

As --crate-version accepts arbitrary strings they need to be escaped.

rust-highfive · 2020-03-01T00:04:48Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-29T23:48:30.7656068Z ========================== Starting Command Output ===========================
2020-02-29T23:48:30.7659052Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/52a7c53f-6511-4298-b3de-a811358cb2bc.sh
2020-02-29T23:48:30.7659337Z 
2020-02-29T23:48:30.7661946Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-29T23:48:30.7681862Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69598/merge to s
2020-02-29T23:48:30.7685246Z Task         : Get sources
2020-02-29T23:48:30.7685461Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-29T23:48:30.7685707Z Version      : 1.0.0
2020-02-29T23:48:30.7685847Z Author       : Microsoft
---
2020-02-29T23:48:32.0279930Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-29T23:48:32.0290801Z ##[command]git config gc.auto 0
2020-02-29T23:48:32.0299163Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-29T23:48:32.0305561Z ##[command]git config --get-all http.proxy
2020-02-29T23:48:32.0318760Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69598/merge:refs/remotes/pull/69598/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

As `--crate-version` accepts arbitrary strings they need to be escaped.

GuillaumeGomez · 2020-03-01T10:58:59Z

Thanks!

@bors: r+ rollup

bors · 2020-03-01T10:59:01Z

📌 Commit 3c97f8a has been approved by GuillaumeGomez

@ghost

Rollup of 7 pull requests Successful merges: - #69504 (Use assert_ne in hash tests) - #69554 (Cleanup e0374) - #69568 (Clarify explanation of Vec<T> 'fn resize') - #69569 (simplify boolean expressions) - #69577 (Clean up E0375 explanation) - #69598 (rustdoc: HTML escape crate version) - #69607 (Clean up E0376 explanation) Failed merges: r? @ghost

rust-highfive assigned GuillaumeGomez Feb 29, 2020

rustdoc: HTML escape crate version

3c97f8a

As `--crate-version` accepts arbitrary strings they need to be escaped.

ollie27 force-pushed the rustdoc_crate-version_escape branch from 03406ec to 3c97f8a Compare March 1, 2020 00:15

JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2020

Dylan-DPC-zz mentioned this pull request Mar 1, 2020

Rollup of 7 pull requests #69612

Merged

bors merged commit 22a0391 into rust-lang:master Mar 1, 2020

ollie27 deleted the rustdoc_crate-version_escape branch March 1, 2020 22:10

jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustdoc: HTML escape crate version #69598

rustdoc: HTML escape crate version #69598

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!