Tweak binding lifetime suggestion text #69305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have a structured suggestion, but the wording made it seem like that wasn't the case. Fix rust-lang#65286. r? @varkor
|
@bors r+ rollup |
|
📌 Commit c816430 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 20, 2020
Rollup of 5 pull requests Successful merges: - #68877 (On mismatched argument count point at arguments) - #69185 (Unify and improve const-prop lints) - #69305 (Tweak binding lifetime suggestion text) - #69311 (Clean up E0321 and E0322) - #69317 (Fix broken link to the rustc guide) Failed merges: r? @ghost
varkor
reviewed
Feb 20, 2020
| @@ -4,7 +4,7 @@ error[E0310]: the parameter type `T` may not live long enough | |||
| LL | impl <T: Sync> Foo for T { } | |||
| | -- ^^^ | |||
| | | | |||
| | help: consider adding an explicit lifetime bound `T: 'static`... | |||
| | help: consider adding an explicit lifetime bound...: `T: 'static +` | |||
There was a problem hiding this comment.
Ellipsis followed by a colon looks a little strange. Maybe
help: consider adding an explicit lifetime bound: `T: 'static + ...`
would work better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a structured suggestion, but the wording made it seem like that wasn't the case.
Fix #65286. r? @varkor