10000 Stabilize assoc_int_consts associated int/float constants by faern · Pull Request #68952 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

Stabilize assoc_int_consts associated int/float constants #68952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 4, 2020
Merged

Stabilize assoc_int_consts associated int/float constants #68952

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
271ba5a
Stabilize assoc_int_consts
faern Feb 4, 2020
3529834
Add "soft deprecation" notice to old min/max_value() docs
faern Feb 4, 2020
97bdd31
Add "soft deprecation" notice to old MIN/MAX docs
faern Feb 4, 2020
fd71fbe
Remove reference from integer docs to their modules
faern Feb 10, 2020
cf255c6
Use new preferred consts in int docs
faern Feb 4, 2020
5e17f31
Replace min/max_value() with MIN/MAX in integer docs
faern Feb 4, 2020
847a0dd
Remove uint_macros that was identical to int_macros
faern Feb 4, 2020
c67de25
Add notice about using new consts in new code on float modules
faern Feb 10, 2020
0869274
Add notice about using new consts in new code on int modules
faern Feb 4, 2020
83191c2
Update float documentation to use associated consts
faern Feb 4, 2020
b2dc618
Add usage recommendation to old float constants
faern Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add "soft deprecation" notice to old min/max_value() docs
  • Loading branch information
@faern
faern committed Feb 12, 2020
commit 35298349c3efd75cd8050f9f23e4bf1409d96118
100 changes: 60 additions & 40 deletions src/libcore/num/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,28 +279,6 @@ $EndFeature, "
pub const MAX: Self = !Self::MIN;
}

doc_comment! {
"Returns the smallest value that can be represented by this integer type.",
#[stable(feature = "rust1", since = "1.0.0")]
#[inline(always)]
#[rustc_promotable]
#[rustc_const_stable(feature = "const_min_value", since = "1.32.0")]
pub const fn min_value() -> Self {
Self::MIN
}
}

doc_comment! {
"Returns the largest value that can be represented by this integer type.",
#[stable(feature = "rust1", since = "1.0.0")]
#[inline(always)]
#[rustc_promotable]
#[rustc_const_stable(feature = "const_max_value", since = "1.32.0")]
pub const fn max_value() -> Self {
Self::MAX
}
}

doc_comment! {
concat!("Converts a string slice in a given base to an integer.

Expand Down Expand Up @@ -2351,6 +2329,38 @@ fn read_ne_", stringify!($SelfT), "(input: &mut &[u8]) -> ", stringify!($SelfT),
unsafe { mem::transmute(bytes) }
}
}

doc_comment! {
concat!("**This method is soft-deprecated.**

Although using it won’t cause compilation warning,
new code should use [`", stringify!($SelfT), "::MIN", "`](#associatedconstant.MIN) instead.

Returns the smallest value that can be represented by this integer type."),
#[stable(feature = "rust1", since = "1.0.0")]
#[inline(always)]
#[rustc_promotable]
#[rustc_const_stable(feature = "const_min_value", since = "1.32.0")]
pub const fn min_value() -> Self {
Self::MIN
}
}

doc_comment! {
concat!("**This method is soft-deprecated.**

Although using it won’t cause compilation warning,
new code should use [`", stringify!($SelfT), "::MAX", "`](#associatedconstant.MAX) instead.

Returns the largest value that can be represented by this integer type."),
#[stable(feature = "rust1", since = "1.0.0")]
#[inline(always)]
#[rustc_promotable]
#[rustc_const_stable(feature = "const_max_value", since = "1.32.0")]
pub const fn max_value() -> Self {
Self::MAX
}
}
}
}

Expand Down Expand Up @@ -2454,24 +2464,6 @@ $EndFeature, "
pub const MAX: Self = !0;
}

doc_comment! {
"Returns the smallest value that can be represented by this integer type.",
#[stable(feature = "rust1", since = "1.0.0")]
#[rustc_promotable]
#[inline(always)]
#[rustc_const_stable(feature = "const_max_value", since = "1.32.0")]
pub const fn min_value() -> Self { Self::MIN }
}

doc_comment! {
"Returns the largest value that can be represented by this integer type.",
#[stable(feature = "rust1", since = "1.0.0")]
#[rustc_promotable]
#[inline(always)]
#[rustc_const_stable(feature = "const_max_value", since = "1.32.0")]
pub const fn max_value() -> Self { Self::MAX }
}

doc_comment! {
concat!("Converts a string slice in a given base to an integer.

Expand Down Expand Up @@ -4277,6 +4269,34 @@ fn read_ne_", stringify!($SelfT), "(input: &mut &[u8]) -> ", stringify!($SelfT),
unsafe { mem::transmute(bytes) }
}
}

doc_comment! {
concat!("**This method is soft-deprecated.**

Although using it won’t cause compilation warning,
new code should use [`", stringify!($SelfT), "::MIN", "`](#associatedconstant.MIN) instead.

Returns the smallest value that can be represented by this integer type."),
#[stable(feature = "rust1", since = "1.0.0")]
#[rustc_promotable]
#[inline(always)]
#[rustc_const_stable(feature = "const_max_value", since = "1.32.0")]
pub const fn min_value() -> Self { Self::MIN }
}

doc_comment! {
concat!("**This method is soft-deprecated.**

Although using it won’t cause compilation warning,
new code should use [`", stringify!($SelfT), "::MAX", "`](#associatedconstant.MAX) instead.

Returns the largest value that can be represented by this integer type."),
#[stable(feature = "rust1", since = "1.0.0")]
#[rustc_promotable]
#[inline(always)]
#[rustc_const_stable(feature = "const_max_value", since = "1.32.0")]
pub const fn max_value() -> Self { Self::MAX }
}
}
}

Expand Down
0