8000 Use a DFS to compare CTFE snapshots by ecstatic-morse · Pull Request #66946 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

Use a DFS to compare CTFE snapshots #66946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Use a DFS to compare CTFE snapshots #66946

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6faae4d
Add `erase_alloc_id` method to various Miri primitives
ecstatic-morse Dec 8, 2019
f0148a5
Derive `Hash` and `Eq` for some Miri primitives
ecstatic-morse Dec 8, 2019
840e323
Add DFS iterator for `Memory`
ecstatic-morse Dec 8, 2019
fa5ff3a
Remove unused `Clone` impl for `Memory`
ecstatic-morse Dec 8, 2019
37844e5
Reimplement CTFE snapshot comparison using a DFS
ecstatic-morse Dec 8, 2019
26b9146
Rename `is_empty` to `has_been_invoked`
ecstatic-morse Dec 8, 2019
345a8d5
Move `CtfeMemory` alias next to `CompileTimeInterpreter`
ecstatic-morse Dec 8, 2019
e017f57
Fix typo
ecstatic-morse Dec 9, 2019
afb4faa
Hash discriminant of `LocalValue`
ecstatic-morse Dec 9, 2019
ba22627
Ensure promotion does not prevent generation of new `AllocId`s
ecstatic-morse Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused Clone impl for Memory
  • Loading branch information
@ecstatic-morse
ecstatic-morse committed Dec 9, 2019
commit fa5ff3afa6657d0a9832a5f1616edd4a2a401ea7
18 changes: 0 additions & 18 deletions src/librustc_mir/interpret/memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,24 +114,6 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> HasDataLayout for Memory<'mir, 'tcx, M>
}
}

// FIXME: Really we shouldn't clone memory, ever. Snapshot machinery should instead
// carefully copy only the reachable parts.
impl<'mir, 'tcx, M> Clone for Memory<'mir, 'tcx, M>
where
M: Machine<'mir, 'tcx, PointerTag = (), AllocExtra = (), MemoryExtra = ()>,
M::MemoryMap: AllocMap<AllocId, (MemoryKind<M::MemoryKinds>, Allocation)>,
{
fn clone(&self) -> Self {
Memory {
alloc_map: self.alloc_map.clone(),
extra_fn_ptr_map: self.extra_fn_ptr_map.clone(),
dead_alloc_map: self.dead_alloc_map.clone(),
extra: (),
tcx: self.tcx,
}
}
}

impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> Memory<'mir, 'tcx, M> {
pub fn new(tcx: TyCtxtAt<'tcx>, extra: M::MemoryExtra) -> Self {
Memory {
Expand Down
0