skip all refs-to-uninit-local, not just arguments

rust-lang · bors · Oct 21, 2019 · Oct 19, 2019 · Oct 19, 2019 · Oct 20, 2019
commit f907fbe1a6676a26cfc893b78f0fffb4285f1e6c
diff --git a/src/librustc_mir/transform/const_prop.rs b/src/librustc_mir/transform/const_prop.rs
@@ -523,18 +523,19 @@ impl<'mir, 'tcx> ConstPropagator<'mir, 'tcx> {
             // local. There's nothing it can do here: taking a reference needs an allocation
             // which needs to know the size. Normally that's okay as during execution
             // (e.g. for CTFE) it can never happen. But here in const_prop
-            // we leave function arguments uninitialized, so if one of these is unsized
+            // unknown data is uninitialized, so if e.g. a function argument is unsized
             // and has a reference taken, we get an ICE.
             Rvalue::Ref(_, _, Place { base: PlaceBase::Local(local), projection: box [] }) => {
                 trace!("checking Ref({:?})", place);
                 let alive =
                     if let LocalValue::Live(_) = self.ecx.frame().locals[*local].value {
                         true
-                    } else { false };
+                    } else {
+                        false
+                    };
 
-                // local 0 is the return place; locals 1..=arg_count are the arguments.
-                if local.as_usize() <= self.ecx.frame().body.arg_count && !alive {
-                    trace!("skipping Ref({:?})", place);
+                if !alive {
+                    trace!("skipping Ref({:?}) to uninitialized local", place);
                     return None;
                 }
             }