8000 Snapshot clean-ups by nnethercote · Pull Request #64939 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

Snapshot clean-ups #64939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Snapshot clean-ups #64939

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f9aea1
Clarify a comment in `RegionConstraintCollector::leak_check`.
nnethercote Sep 30, 2019
1b41f95
Remove `InferCtxt::in_snapshot()`.
nnethercote Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Clarify a comment in RegionConstraintCollector::leak_check.
  • Loading branch information
@nnethercote
nnethercote committed Oct 8, 2019
commit 3f9aea199ceefef9855850ab7843ef6935055eca
8 changes: 5 additions & 3 deletions src/librustc/infer/region_constraints/leak_check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ impl<'tcx> RegionConstraintCollector<'tcx> {
/// retain the older (arguably incorrect) behavior of the
/// compiler.
///
/// NB. The use of snapshot here is mostly an efficiency thing --
/// we could search *all* region constraints, but that'd be a
/// bigger set and the data structures are not setup for that. If
/// NB. Although `_snapshot` isn't used, it's passed in to prove
/// that we are in a snapshot, which guarantees that we can just
/// search the "undo log" for edges. This is mostly an efficiency
/// thing -- we could search *all* region constraints, but that'd be
/// a bigger set and the data structures are not setup for that. If
/// we wind up keeping some form of this check long term, it would
/// probably be better to remove the snapshot parameter and to
/// refactor the constraint set.
Expand Down
0