8000 Add check for overlapping ranges to unreachable patterns lint by estebank · Pull Request #64007 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content
8000

Add check for overlapping ranges to unreachable patterns lint #64007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 19, 2019
Merged

Add check for overlapping ranges to unreachable patterns lint #64007

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
91a3db9
Add check for overlapping ranges to unreachable patterns lint
estebank Aug 29, 2019
220b9b2
Move overlapping patterns to its own lint
estebank Aug 30, 2019
916936c
Silence lint in `fit_signed` and `fit_unsigned`
estebank Aug 30, 2019
d2cb5a8
Move lint emitter to its own method
estebank Aug 30, 2019
be9e6af
review comments: use if let
estebank Aug 30, 2019
1ec6073
Deduplicate code for formatting `RangeEnd`
estebank Aug 30, 2019
6832da8
rename method
estebank Aug 30, 2019
89b19cc
Continue to emit unreachable pattern on cases caught by overlapping p…
estebank Aug 30, 2019
73d6efc
Only emit overlapping patterns lint if the overlap is partial
estebank Oct 7, 2019
593cdcc
Lint only on single element overlap
estebank Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Silence lint in fit_signed and fit_unsigned
  • Loading branch information
@estebank
estebank committed Oct 16, 2019
commit 916936c77488d0a75cc254b5bdc9a787c8ed8768
2 changes: 2 additions & 0 deletions src/librustc_target/abi/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ impl Integer {

/// Finds the smallest Integer type which can represent the signed value.
pub fn fit_signed(x: i128) -> Integer {
#[cfg_attr(not(stage0), allow(overlapping_patterns))]
match x {
-0x0000_0000_0000_0080..=0x0000_0000_0000_007f => I8,
-0x0000_0000_0000_8000..=0x0000_0000_0000_7fff => I16,
Expand All @@ -499,6 +500,7 @@ impl Integer {

/// Finds the smallest Integer type which can represent the unsigned value.
pub fn fit_unsigned(x: u128) -> Integer {
#[cfg_attr(not(stage0), allow(overlapping_patterns))]
match x {
0..=0x0000_0000_0000_00ff => I8,
0..=0x0000_0000_0000_ffff => I16,
Expand Down
0