[const-prop] Support Rvalue::{Ref,Len} and Deref #61532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Jun 5, 2019
174518c to
a1aa0ee
Compare
|
@bors try |
|
⌛ Trying commit a1aa0ee29240a4737054013910acff3998648ad9 with merge 78f9292a51479346f19ce2c71bdb0db551ce8fe5... |
|
☀️ Try build successful - checks-travis |
|
@rust-timer build 78f9292a51479346f19ce2c71bdb0db551ce8fe5 |
|
Success: Queued 78f9292a51479346f19ce2c71bdb0db551ce8fe5 with parent 7cdaffd, comparison URL. |
|
Finished benchmarking try commit 78f9292a51479346f19ce2c71bdb0db551ce8fe5, comparison URL. |
|
Awesome improvements, sprinkled with some small regressions. The worst is the 3-4% clean incremental regression for |
This fixes an ICE when building libcore with `-Z mir-opt-level=3`.
a1aa0ee to
dee05ab
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
📌 Commit 459e37b has been approved by |
|
⌛ Testing commit 459e37b with merge 5ca98982963a5e10ec21d76d608e9bfe47771c3a... |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry (timeout) |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 7, 2019
[const-prop] Support Rvalue::{Ref,Len} and Deref
Also fixes an ICE I found in testing.
r? @oli-obk
~~The final commit is just for a perf run. I'll remove it after that is completed.~~
bors
added a commit
that referenced
this pull request
Jun 7, 2019
Rollup of 4 pull requests Successful merges: - #61332 (Remove asterisk suggestion for move errors in borrowck) - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref) - #61586 (ci: Disable LLVM/debug assertions for asmjs builder) - #61599 (libcore/pin: Minor grammar corrections for module documentation) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 7, 2019
[const-prop] Support Rvalue::{Ref,Len} and Deref
Also fixes an ICE I found in testing.
r? @oli-obk
~~The final commit is just for a perf run. I'll remove it after that is completed.~~
bors
added a commit
that referenced
this pull request
Jun 7, 2019
Rollup of 7 pull requests Successful merges: - #61332 (Remove asterisk suggestion for move errors in borrowck) - #61532 ([const-prop] Support Rvalue::{Ref,Len} and Deref) - #61586 (ci: Disable LLVM/debug assertions for asmjs builder) - #61599 (libcore/pin: Minor grammar corrections for module documentation) - #61603 (Increases heap size available during testing for SGX) - #61605 6D40 (Fix slice const generic length display) - #61618 (make the backtrace field of EvalError private) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an ICE I found in testing.
r? @oli-obk
The final commit is just for a perf run. I'll remove it after that is completed.