8000 Rollup of 12 pull requests by Centril · Pull Request #59428 · rust-lang/rust · GitHub
[go: up one dir, main page]

Skip to content

Rollup of 12 pull requests #59428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 50 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
7fb1c22
promoted is still left in 2 places
Mar 16, 2019
a837b8a
cleaner code as per review
Mar 17, 2019
23c87a1
fixed all compilation errors
Mar 18, 2019
ac6ab65
adjust MaybeUninit API to discussions
RalfJung Mar 18, 2019
776407e
tidy checks
Mar 19, 2019
9374efa
fix some uses I missed
RalfJung Mar 19, 2019
8829dda
remove visit_static from librustc::mir
Mar 20, 2019
72f8d4e
Add no_hash to query macro and move some queries over
Zoxc Mar 20, 2019
b440041
Allow itertools
Zoxc Mar 20, 2019
d060e7d
Add no_force to query macro and move some queries over
Zoxc Mar 20, 2019
52374a6
Add anon to query macro and move a query over
Zoxc Mar 20, 2019
4d0a1e4
Add eval_always to query macro and move a query over
Zoxc Mar 20, 2019
75677c4
Fix whitespace
Zoxc Mar 20, 2019
71dfb01
Update build instructions in README.md
ewk Mar 21, 2019
cf2f1bb
review fixes
Mar 20, 2019
48af718
Expand `impl FromIterator for Option` doc to include example of early…
pnkfelix Mar 20, 2019
d5a61c0
Expand `impl FromIterator for Result` doc to include examples of `Err…
pnkfelix Mar 20, 2019
b34a71b
add suggestions to trim_{left,right} deprecations
euclio Mar 22, 2019
37cfeb2
Add/rename checked_duration_since tests
faern Mar 22, 2019
d56b1fd
Make duration_since use checked_duration_since
faern Mar 22, 2019
1ccad16
Update sys::time impls to have checked_sub_instant
faern Mar 22, 2019
8ba1a97
Expand suggestions for type ascription parse errors
estebank Mar 13, 2019
b1a6c32
Tweak labels
estebank Mar 13, 2019
72a3089
Only suggest let assignment for type ascription if we find an equals …
estebank Mar 13, 2019
81b876b
Hide "type ascription is experimental error" unless it's the only one
estebank Mar 13, 2019
44a086e
Review comment
estebank Mar 20, 2019
d72ef21
Reword type ascription note to reduce verbosity
estebank Mar 23, 2019
752544b
adding mir::StaticKind enum for static and promoted
Mar 23, 2019
fb93f10
code review fixes
Mar 24, 2019
8d7c2bb
replace redundant note in deprecation warning
euclio Mar 24, 2019
f5d6b3a
Moves test::black_box to core::hint
gnzlbg Mar 21, 2019
f244383
Remove dupplicated config
gnzlbg Mar 25, 2019
6315221
Update src/libcore/option.rs
killercup Mar 25, 2019
cfa76c4
black_box should inhibit optimizations on platforms without inline as…
gnzlbg Mar 25, 2019
0e83e96
add missing braces
pnkfelix Mar 25, 2019
0bb36a2
Clarify `{Ord,f32,f64}::clamp` docs a little
tbu- Mar 25, 2019
24db517
black_box should use inline assembly on wasm32
gnzlbg Mar 25, 2019
28c602a
Utilize `?` instead of `return None`.
frewsxcv Mar 25, 2019
3e7a5fd
Rollup merge of #59150 - estebank:type-ascription, r=varkor
Centril Mar 26, 2019
01af178
Rollup merge of #59232 - saleemjaffer:mir_place_refactor, r=oli-obk
Centril Mar 26, 2019
e061309
Rollup merge of #59284 - RalfJung:maybe-uninit, r=sfackler
Centril Mar 26, 2019
205d20a
Rollup merge of #59315 - Zoxc:move-query, r=oli-obk
Centril Mar 26, 2019
7b70515
Rollup merge of #59334 - ewk:readme, r=Mark-Simulacrum
Centril Mar 26, 2019
f9ae15f
Rollup merge of #59336 - gnzlbg:hint_black_box, r=alexcrichton
Centril Mar 26, 2019
ea51c8b
Rollup merge of #59362 - pnkfelix:demo-from-iterator-short-circuiting…
Centril Mar 26, 2019
cb15da7
Rollup merge of #59372 - euclio:rename-trim, r=rkruppe
Centril Mar 26, 2019
8aa161b
Rollup merge of #59374 - faern:simplify-checked-duration-since, r=she…
Centril Mar 26, 2019
e5f4755
Rollup merge of #59389 - euclio:deprecated-suggestion, r=varkor
Centril Mar 26, 2019
25f3ae9
Rollup merge of #59410 - tbu-:pr_doc_clarifyclamp, r=joshtriplett
Centril Mar 26, 2019
5059a9a
Rollup merge of #59419 - frewsxcv:frewsxcv-qu, r=varkor
Centril Mar 26, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Utilize ? instead of return None.
  • Loading branch information
frewsxcv committed Mar 25, 2019
commit 28c602a94ebe15b45cfda59a4681d6916901aa40
6 changes: 2 additions & 4 deletions src/libcore/num/flt2dec/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,8 @@ impl<'a> Formatted<'a> {

let mut written = self.sign.len();
for part in self.parts {
match part.write(&mut out[written..]) {
Some(len) => { written += len; }
None => { return None; }
}
let len = part.write(&mut out[written..])?;
written += len;
}
Some(written)
}
Expand Down
6 changes: 1 addition & 5 deletions src/librustc/traits/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -292,11 +292,7 @@ impl<'cx, 'gcx, 'tcx> Iterator for SupertraitDefIds<'cx, 'gcx, 'tcx> {
type Item = DefId;

fn next(&mut self) -> Option<DefId> {
let def_id = match self.stack.pop() {
Some(def_id) => def_id,
None => { return None; }
};

let def_id = self.stack.pop()?;
let predicates = self.tcx.super_predicates_of(def_id);
let visited = &mut self.visited;
self.stack.extend(
Expand Down
5 changes: 1 addition & 4 deletions src/librustc_typeck/check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5318,10 +5318,7 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
) -> Option<Span> {
// Be helpful when the user wrote `{... expr;}` and
// taking the `;` off is enough to fix the error.
let last_stmt = match blk.stmts.last() {
Some(s) => s,
None => return None,
};
let last_stmt = blk.stmts.last()?;
let last_expr = match last_stmt.node {
hir::StmtKind::Semi(ref e) => e,
_ => return None,
Expand Down
0