8000 allow compiletest to pass down `--extern` flags by qmx · Pull Request #54020 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

allow compiletest to pass down --extern flags #54020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

allow compiletest to pass down --extern flags #54020

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3ed8b02
extract helper fn
qmx Sep 6, 2018
f9e988c
try to make this testable
qmx Sep 6, 2018
945577f
add negative test
qmx Sep 6, 2018
7f4f0a4
add name-kv parser
qmx Sep 6, 2018
920f259
expose aux_crate through Config
qmx Sep 7, 2018
d735cfb
extract helper
qmx Sep 7, 2018
1beca83
expose fields
qmx Sep 7, 2018
bd0280a
compile aux_crates before compiling the test
qmx Sep 7, 2018
4b0cbef
pass down desired crate name to rustc
qmx Sep 7, 2018
e552319
add tests
qmx Sep 7, 2018
b982ecf
tidy up
qmx Sep 7, 2018
99e5699
port extern-prelude test to aux-crate
qmx Sep 8, 2018
7dd0e38
tidy up
qmx Sep 8, 2018
90132e0
try to make this cross-platform safe
qmx Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pass down desired crate name to rustc
  • Loading branch information
@qmx
qmx committed Oct 21, 2018
commit 4b0cbefd58e568baeecaca1c6c23e9aba828f449
5 changes: 5 additions & 0 deletions src/tools/compiletest/src/runtest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,6 +1571,11 @@ impl<'test> TestCx<'test> {
}

rustc.envs(self.props.rustc_env.clone());

for aux_crate in &self.props.aux_crates {
rustc.arg(format!("--extern {}={}", aux_crate.key, aux_crate.value));
}

self.compose_and_run(
rustc,
self.config.compile_lib_path.to_str().unwrap(),
Expand Down
0