8000 Rollup of 20 pull requests by pietroalbini · Pull Request #53832 · rust-lang/rust · GitHub
[go: up one dir, main page]

Skip to content

Rollup of 20 pull requests #53832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Aug 31, 2018
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
931eb4c
Add one more example for Cow that shows how to keep Cow in a struct
kpp Aug 6, 2018
9a3a12e
Fix review notes
kpp Aug 15, 2018
34b65db
document effect of join on memory ordering
RalfJung Aug 15, 2018
5bfb785
Review fix
kpp Aug 15, 2018
b73843f
Force-inline `shallow_resolve` at its hottest call site.
nnethercote Aug 17, 2018
3995bff
Add another PartialEq example
GuillaumeGomez Aug 21, 2018
9395a02
Fix stabilisation version for macro_vis_matcher.
jkozlowski Aug 25, 2018
1f421d6
call span_suggestion with applicability
jcpst Aug 26, 2018
26f38c0
Do not suggest dereferencing in macro
estebank Aug 26, 2018
a2722f3
readd final newline
estebank Aug 27, 2018
4570ace
save-analysis: Differentiate foreign functions and statics.
emilio Aug 18, 2018
c874e36
add llvm-readobj to llvm-tools-preview
japaric Aug 27, 2018
8486efa
fix a typo: taget_env -> target_env
oconnor663 Aug 27, 2018
1d79d8b
Fix source automatic scroll
GuillaumeGomez Aug 27, 2018
04b4c40
Fix invalid display of unstable messages
GuillaumeGomez Aug 27, 2018
f77ad5c
remove `let x = baz` which was obscuring the real error
nikomatsakis Aug 6, 2018
e6dcdee
expand keep-stage --help text
RalfJung Aug 28, 2018
31b63d0
split paragraph
RalfJung Aug 28, 2018
1311339
Fix typo in comment
dmerejkowsky Aug 28, 2018
84796cb
sort
japaric Aug 28, 2018
93f3f5b
Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere i…
eddyb Aug 18, 2018
6628d39
move file-extension based .gitignore down to src/
RalfJung Aug 28, 2018
da4febd
Add partialeq implementation for TryFromIntError type
GuillaumeGomez Aug 18, 2018
890d04d
Fix a comment in src/libcore/slice/mod.rs
tbu- Aug 29, 2018
e477a13
Replace usages of 'bad_style' with 'nonstandard_style'.
frewsxcv Aug 29, 2018
e08a84a
Fix UI issues on Implementations on Foreign types
GuillaumeGomez Aug 29, 2018
b7e74a5
Rollup merge of #51760 - GuillaumeGomez:add-another-partialeq-example…
pietroalbini Aug 30, 2018
2531d43
Rollup merge of #53113 - kpp:more_docs_for_cow, r=GuillaumeGomez
pietroalbini Aug 30, 2018
8505270
Rollup merge of #53129 - nikomatsakis:issue-51172-tweak-test, r=pnkfelix
pietroalbini Aug 30, 2018
0c8b8e8
Rollup merge of #53389 - RalfJung:thread-join, r=sfackler
pietroalbini Aug 30, 2018
ba83270
Rollup merge of #53472 - eddyb:fx-pls, r=pnkfelix
pietroalbini Aug 30, 2018
a245d9b
Rollup merge of #53476 - GuillaumeGomez:try-from-int-error-partial-eq…
pietroalbini Aug 30, 2018
1c36e76
Rollup merge of #53513 - nnethercote:inline-shallow_resolve, r=varkor
pietroalbini Aug 30, 2018
1535075
Rollup merge of #53655 - jcpst:with_applicability, r=estebank
pietroalbini Aug 30, 2018
3ee7628
Rollup merge of #53702 - jkozlowski:correct_version_for_macro_vis_mat…
pietroalbini Aug 30, 2018
0334ce4
Rollup merge of #53727 - estebank:incorrect-deref-suggestion, r=nikom…
pietroalbini Aug 30, 2018
ed07680
Rollup merge of #53732 - emilio:foreign-fn, r=nrc
pietroalbini Aug 30, 2018
d52fea8
Rollup merge of #53740 - japaric:readobj, r=alexcrichton
pietroalbini Aug 30, 2018
eaca5f8
Rollup merge of #53743 - oconnor663:target_env, r=kennytm
pietroalbini Aug 30, 2018
2e2980b
Rollup merge of #53747 - GuillaumeGomez:rustdoc-fixes, r=QuietMisdreavus
pietroalbini Aug 30, 2018
ad9a001
Rollup merge of #53753 - RalfJung:keep-stage, r=nikomatsakis
pietroalbini Aug 30, 2018
11fab7d
Rollup merge of #53756 - dmerejkowsky:fix-comment, r=KodrAus
pietroalbini Aug 30, 2018
c9862e2
Rollup merge of #53768 - RalfJung:gitignore, r=nikomatsakis
pietroalbini Aug 30, 2018
07fcb01
Rollup merge of #53785 - tbu-:pr_comment, r=Mark-Simulacrum
pietroalbini Aug 30, 2018
78d5509
Rollup merge of #53786 - frewsxcv:frewsxcv-bad-style, r=Manishearth
pietroalbini Aug 30, 2018
6b1fffa
Rollup merge of #53806 - GuillaumeGomez:fix-ui-issues-foreign-type-im…
pietroalbini Aug 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in comment
  • Loading branch information
dmerejkowsky committed Aug 28, 2018
commit 13113391a08161a3e9583e47f98da23bd9cf2445
2 changes: 1 addition & 1 deletion src/libstd/sys/unix/fd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ impl Drop for FileDesc {
// reason for this is that if an error occurs we don't actually know if
// the file descriptor was closed or not, and if we retried (for
// something like EINTR), we might close another valid file descriptor
// (opened after we closed ours.
// opened after we closed ours.
let _ = unsafe { libc::close(self.fd) };
}
}
0