8000 [rustbuild] Implement testing and refactor configuration by Mark-Simulacrum · Pull Request #48521 · rust-lang/rust · GitHub
[go: up one dir, main page]

Skip to content

[rustbuild] Implement testing and refactor configuration #48521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
1c55459
[VIC] Prevent bootstrap test from overwriting initial compile
Mark-Simulacrum Feb 11, 2018
e72b895
Remove ONLY_BUILD_TARGETS.
Mark-Simulacrum Feb 11, 2018
f61d354
Remove ONLY_BUILD.
Mark-Simulacrum Feb 11, 2018
3124b25
Refactor run_host_only to have the proper effect.
Mark-Simulacrum Feb 11, 2018
48923dd
[VIC] Remove --host and --target arguments to configure
Mark-Simulacrum Feb 11, 2018
9321fba
Refactor to improve readability.
Mark-Simulacrum Feb 11, 2018
3ae9c7a
Avoid only-hosts to change what is built.
Mark-Simulacrum Feb 11, 2018
db0d96d
Remove unused fields on Crate struct
Mark-Simulacrum Feb 14, 2018
9a8af65
[VIC] Fix cross-compiling rustdoc.
Mark-Simulacrum Feb 15, 2018
7f1426d
Print out the sysroot and libdir on verbose builds.
Mark-Simulacrum Feb 15, 2018
23109dc
Pull paths out of Subcommand enum
Mark-Simulacrum Feb 16, 2018
5cd0002
Move StepDescription::run to Builder::run_step_descriptions.
Mark-Simulacrum Feb 16, 2018
67e6482
Deny warnings
Mark-Simulacrum Feb 16, 2018
ba7a588
Remove src from Build
Mark-Simulacrum Feb 16, 2018
b11dae6
Remove out from Build
Mark-Simulacrum Feb 17, 2018
ca2e204
Remove initial_rustc and initial_cargo from Build
Mark-Simulacrum Feb 17, 2018
7826a74
Remove local_rebuild from Build
Mark-Simulacrum Feb 17, 2018
ca059b9
Move is_sudo to Config
Mark-Simulacrum Feb 17, 2018
cb447a7
Remove hosts from Build
Mark-Simulacrum Feb 17, 2018
ff5117b
Remove targets from Build
Mark-Simulacrum Feb 17, 2018
13d97f3
Remove build from Build
Mark-Simulacrum Feb 17, 2018
9a695be
Remove verbosity from Build
Mark-Simulacrum Feb 17, 2018
f0185ec
Remove fail_fast from Build
Mark-Simulacrum Feb 17, 2018
9fe9348
Build is default-able
Mark-Simulacrum Feb 17, 2018
2b0ce18
Refactor default values for configuration into Default
Mark-Simulacrum Feb 18, 2018
ed4d1e0
Cleanup to config
Mark-Simulacrum Feb 18, 2018
aca2d80
Stop copying llvm configuration from Llvm struct
Mark-Simulacrum Feb 18, 2018
d4e7d53
Cleanup target creation
Mark-Simulacrum Feb 18, 2018
e276ba7
Stop copying install configuration from Install struct
Mark-Simulacrum Feb 18, 2018
a096036
Remove doc_tests from Build
Mark-Simulacrum Feb 18, 2018
483e099
Stop copying dist configuration from Dist struct
Mark-Simulacrum Feb 18, 2018
15a90fa
Stop copying rust configuration from Rust struct
Mark-Simulacrum Feb 19, 2018
2c3860e
Regroup Config
Mark-Simulacrum Feb 19, 2018
c492b71
Stop copying build configuration from Build struct
Mark-Simulacrum Feb 19, 2018
13a4184
Prepare initial_{cargo,rustc} for removal from Config
Mark-Simulacrum Feb 20, 2018
34d1be2
Cleanup hosts/targets handling
Mark-Simulacrum Feb 20, 2018
7ea1d36
Let bootstrap.py handle build triple configuration
Mark-Simulacrum Feb 20, 2018
ff40909
Simplify internment
Mark-Simulacrum Feb 21, 2018
db2187d
Use Intern::intern instead of intern_{string,str,path}
Mark-Simulacrum Feb 21, 2018
6d922e9
Permit ser/deserializing Interned values
Mark-Simulacrum Feb 21, 2018
423aae7
Cleanup Interned impls to remove 'static bounds
Mark-Simulacrum Feb 21, 2018
6a22f0b
Implement PartialOrd, Ord for Interned
Mark-Simulacrum Feb 21, 2018
4f2a860
Refactor {build,host,target} loading
Mark-Simulacrum Feb 21, 2018
3744f53
Refactor initial_{rustc,cargo} defaults into Build::default
Mark-Simulacrum Feb 21, 2018
75ee753
Create Config directly instead of through Default
Mark-Simulacrum Feb 21, 2018
5147b1e
Remove Default impls for Config and Build
Mark-Simulacrum Feb 21, 2018
c310e4d
Polish config loading
Mark-Simulacrum Feb 22, 2018
d2c266a
Set stage default of 2
Mark-Simulacrum Feb 22, 2018
8ae4f7d
Remove out from Config
Mark-Simulacrum Feb 23, 2018
14b227b
Remove initial_{cargo,rustc} from Config
Mark-Simulacrum Feb 23, 2018
d76bf80
Remove hosts, targets from Config
Mark-Simulacrum Feb 23, 2018
de8ee0d
Remove build from Config
Mark-Simulacrum Feb 23, 2018
7385641
Format via rustfmt
Mark-Simulacrum Feb 23, 2018
16d5fe3
8000 Exclusively utilize Builder in methods
Mark-Simulacrum Feb 23, 2018
7503faa
Clear out build directories from Builder::cargo
Mark-Simulacrum Feb 24, 2018
8e6593b
Call {std,test,rustc}_cargo in Builder::cargo
Mark-Simulacrum Feb 24, 2018
20ded30
[VIC] Move codegen backend mangling to copy step
Mark-Simulacrum Feb 24, 2018
98ce89f
Move run_cargo to Builder
Mark-Simulacrum Feb 24, 2018
2bdbb32
Refactor to prevent passing stamp to run_cargo
Mark-Simulacrum Feb 24, 2018
c2a46fc
Move some of prepare_tool_cargo to Builder
Mark-Simulacrum Feb 24, 2018
a68a8e5
[VIC] Add TestTool and RustcTool modes
Mark-Simulacrum Feb 24, 2018
699689b
[VIC] Build rustc libraries for compiler host for RustcTool
Mark-Simulacrum Feb 24, 2018
a1c22f6
Make cargo invocation start with subcommand
Mark-Simulacrum Feb 24, 2018
b33594a
[VIC] Add tests to Rustbuild
Mark-Simulacrum Feb 25, 2018
2fe3ede
Test extended builds
Mark-Simulacrum Feb 25, 2018
1f43cfa
Use fs::{read,read_string,write} instead of File
Mark-Simulacrum Feb 25, 2018
36849ec
Permit specifying build.build in config.toml
Mark-Simulacrum Feb 25, 2018
022ce70
Write dist-src configure to dist.src-tarball
Mark-Simulacrum Feb 25, 2018
3831685
Add more asserts to test cases
Mark-Simulacrum Feb 25, 2018
a174d0e
Fix tidy
Mark-Simulacrum Feb 25, 2018
d7e8200
Clean up Config::libdir_relative
Mark-Simulacrum Feb 25, 2018
b82a798
Fix compilation error
Mark-Simulacrum Feb 25, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove verbosity from Build
  • Loading branch information
Mark-Simulacrum committed Feb 25, 2018
commit 9a695be42d5da0811fef5ba913da96a7a8469975
2 changes: 1 addition & 1 deletion src/bootstrap/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ impl<'a> Builder<'a> {
cargo.env("RUSTC_ON_FAIL", on_fail);
}

cargo.env("RUSTC_VERBOSE", format!("{}", self.verbosity));
cargo.env("RUSTC_VERBOSE", format!("{}", self.config.verbose));

// Throughout the build Cargo can execute a number of build scripts
// compiling C/C++ code and we need to pass compilers, archivers, flags, etc
Expand Down
6 changes: 2 additions & 4 deletions src/bootstrap/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ pub struct Build {
rustfmt_info: channel::GitInfo,
fail_fast: bool,
doc_tests: bool,
verbosity: usize,

// Probed tools at runtime
lldb_version: Option<String>,
Expand Down Expand Up @@ -295,7 +294,6 @@ impl Build {
Build {
fail_fast: config.cmd.fail_fast(),
doc_tests: config.cmd.doc_tests(),
verbosity: config.verbose,

config,

Expand Down Expand Up @@ -562,11 +560,11 @@ impl Build {
}

pub fn is_verbose(&self) -> bool {
self.verbosity > 0
self.config.verbose > 0
}

pub fn is_very_verbose(&self) -> bool {
self.verbosity > 1
self.config.verbose > 1
}

/// Prints a message if this build is configured in verbose mode.
Expand Down
0