8000 rustc: Disable NEON on armv7 android. by rillian · Pull Request #38413 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

rustc: Disable NEON on armv7 android. #38413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2016
Merged

rustc: Disable NEON on armv7 android. #38413

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e900f6c
rustc: Disable NEON on armv7 android.
rillian Dec 16, 2016
9e01f76
rustc: Link to Android ABI requirements.
rillian Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
rustc: Disable NEON on armv7 android. 
We thought Google's ABI for arvm7 required neon, but it is
currently optional, perhaps because there is a significant
population of Tegra 2 devices still in use.

This turns off neon code generation outside #[target-feature]
blocks just like we do on armv7-unknown-linux-gnu, but unlike
most other armv7 targets. LLVM defaults to +neon for this target,
so an explicit disable is necessary.

See https://developer.android.com/ndk/guides/abis.html#v7a
for instruction set extension requirements.

Closes #38402.
  • Loading branch information
@rillian
rillian committed Dec 16, 2016
commit e900f6c7fe8c077f3a94500c70eee9cfaaa8eff5
4 changes: 2 additions & 2 deletions src/librustc_back/target/armv7_linux_androideabi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
Expand All @@ -12,7 +12,7 @@ use target::{Target, TargetOptions, TargetResult};

pub fn target() -> TargetResult {
let mut base = super::android_base::opts();
base.features = "+v7,+thumb2,+vfp3,+d16".to_string();
base.features = "+v7,+thumb2,+vfp3,+d16,-neon".to_string();
base.max_atomic_width = Some(64);

Ok(Target {
Expand Down
0