8000 autodiff: emit an error if we fail to find libEnzyme by ZuseZ4 · Pull Request #150060 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

autodiff: emit an error if we fail to find libEnzyme #150060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZuseZ4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

autodiff: emit an error if we fail to find libEnzyme #150060

ZuseZ4 wants to merge 1 commit into from
+19 −12

Conversation

@ZuseZ4
Copy link
Member
@ZuseZ4 ZuseZ4 commented Dec 16, 2025 •
edited
Loading

Tested manually by moving libEnzyme-21.so away. We should adjust the error msg. once we have the component up.

It's the first usage within rustc of this experimental feature, but afaik we're open to dogfooding those for test purpose, right?

r? @Kobzol

@rustbot
Copy link
Collaborator
rustbot commented Dec 16, 2025

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2025
@ZuseZ4 ZuseZ4 force-pushed the autodiff-dlopen-ice branch from 7d320f5 to 691c726 Compare December 16, 2025 13:38
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 force-pushed the autodiff-dlopen-ice branch from 691c726 to f36fcd4 Compare December 16, 2025 13:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 force-pushed the autodiff-dlopen-ice branch from f36fcd4 to 90fe221 Compare December 16, 2025 14:06
Kobzol
Kobzol reviewed Dec 16, 2025
View reviewed changes
Copy link
Member
@Kobzol Kobzol left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand it correctly get_or_init has a side-effect of loading the Enzyme dylib, so it's fine to call it and just drop the result?

View changes since this review

@ZuseZ4 ZuseZ4 force-pushed the autodiff-dlopen-ice branch 2 times, most recently from 7e1462d to 29cb8fa Compare December 16, 2025 19:09
@Kobzol
Copy link
Member
Kobzol commented Dec 16, 2025

You can r=me once CI is green.

@ZuseZ4 ZuseZ4 force-pushed the autodiff-dlopen-ice branch from 29cb8fa to 793d990 Compare December 16, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZuseZ4 @rustbot @rust-log-analyzer @Kobzol
0