8000 rustdoc-search: use the same ID for entry and path to same item by notriddle · Pull Request #147045 · rust-lang/rust · GitHub
[go: up one dir, main page]
Skip to content

rustdoc-search: use the same ID for entry and path to same item #147045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

rustdoc-search: use the same ID for entry and path to same item #147045

merged 2 commits into from
Sep 28, 2025

Conversation

notriddle
Copy link
Contributor

This decreases the size of the compiler-doc from 57MiB to 56MiB.

r? @GuillaumeGomez

@notriddle
rustdoc-search: use the same ID for entry and path to same item
b9037f9 
This decreases the size of the compiler-doc from 57MiB to 56MiB.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 25, 2025
@notriddle
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 25, 2025
@rust-bors
Auto merge of #147045 - notriddle:search-index-entrydata-path, r=<try>
8bf899e 
rustdoc-search: use the same ID for entry and path to same item
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 25, 2025
GuillaumeGomez
GuillaumeGomez reviewed Sep 25, 2025
View reviewed changes
src/librustdoc/html/render/search_index.rs
self.alias_pointers.push(alias_pointer);
index
}
fn add_entry(&mut self, name: Symbol, entry_data: EntryData, desc: String) -> usize {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a code comment (or a doc comment on the method) to explain a bit what's being done in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've added a comment.

@rust-bors
Copy link
rust-bors bot commented Sep 25, 2025

☀️ Try build successful (CI)
Build commit: 8bf899e (8bf899e55883b5ffe19019907a81ffd85cadbdf0, parent: eabf390b4ceeb34db9f37e97f435134abbcdea92)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8bf899e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.1%] 4
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 4

Max RSS (memory usage)

Results (primary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Cycles

Results (primary -2.4%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 -4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.601s -> 470.924s (0.07%)
Artifact size: 388.11 MiB -> 388.12 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 26, 2025
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator
bors commented Sep 26, 2025

📌 Commit 9dce3e8 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2025
@Zalathar
Copy link
Contributor

Scheduling: If the rollup fails, fall back to rollup=never instead of rollup=iffy.

@bors p=1

@bors
Copy link
Collaborator
bors commented Sep 28, 2025

⌛ Testing commit 9dce3e8 with merge 4ffeda1...

@bors
Copy link
Collaborator
bors commented Sep 28, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 4ffeda1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2025
@bors bors merged commit 4ffeda1 into rust-lang:master Sep 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 28, 2025
@github-actions GitHub Actions
Copy link
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c7f6aa2 (parent) -> 4ffeda1 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4ffeda10e10d4fa0c8edbd0dd9642d8ae7d3e66e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-windows-gnullvm: 4747.1s -> 5679.3s (19.6%)
  2. i686-gnu-2: 6245.7s -> 5388.6s (-13.7%)
  3. x86_64-gnu-llvm-20: 2856.8s -> 2486.1s (-13.0%)
  4. x86_64-rust-for-linux: 2876.6s -> 2518.4s (-12.5%)
  5. dist-android: 1485.5s -> 1305.0s (-12.2%)
  6. dist-aarch64-msvc: 6034.1s -> 5345.8s (-11.4%)
  7. i686-gnu-1: 8434.3s -> 7494.3s (-11.1%)
  8. dist-x86_64-msvc-alt: 8761.0s -> 9593.7s (9.5%)
  9. dist-apple-various: 3523.4s -> 3189.1s (-9.5%)
  10. x86_64-gnu-llvm-20-1: 3573.0s -> 3252.0s (-9.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4ffeda1): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.1%] 3
Improvements ✅
(secondary)		 -0.2% [-0.4%, -0.1%] 2
All ❌✅ (primary) -0.1% [-0.2%, -0.1%] 3

Max RSS (memory usage)

Results (primary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.3% [2.1%, 4.6%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.8% [-1.2%, 4.6%] 3

Cycles

Results (primary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% [-3.2%, -2.1%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-3.2%, 3.0%] 3

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 470.617s -> 469.714s (-0.19%)
Artifact size: 387.65 MiB -> 387.67 MiB (0.00%)

@notriddle notriddle deleted the search-index-entrydata-path branch September 30, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@notriddle @rust-timer @GuillaumeGomez @bors @Zalathar @rustbot
0